Re: [netfilter-core] Re: [lockup] 2.6.17-rc3: netfilter/sctp: lockup in sctp_new(), do_basic_checks()

Ingo Molnar
2006-05-02T14:33:34Z

* Patrick McHardy <kaber@trash.net> wrote:

> > + /*
> > + * Dont trust the initial offset:
> > + */
> > + offset = skb->nh.iph->ihl * 4 + sizeof(sctp_sctphdr_t);
> > + if (offset >= skb->len)
> > + return 1;
> > +
>
> That part is unnecessary, the presence of one sctp_sctphdr_t
> has already been verified by skb_header_pointer() in sctp_new().

ok.

> How about this patch (based on your patch, but typos fixed and also
> covers nf_conntrack)?

sure, fine with me!

Ingo