From: Matt Mackall <mpm@selenic.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] clean-up initcall warning for netconsole
Date: Tue, 2 May 2006 17:44:11 -0500 [thread overview]
Message-ID: <20060502224411.GG15445@waste.org> (raw)
In-Reply-To: <20060428105403.250eb2d6.akpm@osdl.org>
On Fri, Apr 28, 2006 at 10:54:03AM -0700, Andrew Morton wrote:
> Yeah. I think netconsole is just being wrong here. If it wasn't enabled
> there's no error.
Here's a fix:
Index: 2.6/drivers/net/netconsole.c
===================================================================
--- 2.6.orig/drivers/net/netconsole.c 2006-05-02 17:28:43.000000000 -0500
+++ 2.6/drivers/net/netconsole.c 2006-05-02 17:43:37.000000000 -0500
@@ -107,7 +107,7 @@ static int init_netconsole(void)
if(!configured) {
printk("netconsole: not configured, aborting\n");
- return -EINVAL;
+ return 0;
}
if(netpoll_setup(&np))
--
Mathematics is the supreme nostalgia of our time.
prev parent reply other threads:[~2006-05-02 22:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-28 12:06 initcall warnings in 2.6.17 Andi Kleen
2006-04-28 17:54 ` Andrew Morton
2006-04-28 18:14 ` Pavel Machek
2006-05-02 11:28 ` Pavel Machek
2006-05-02 22:44 ` Matt Mackall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060502224411.GG15445@waste.org \
--to=mpm@selenic.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox