From: Ingo Molnar <mingo@elte.hu>
To: Keith Owens <kaos@sgi.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [patch, 2.6.17-rc3-mm1] i386: break out of recursion in stackframe walk
Date: Wed, 3 May 2006 09:08:11 +0200 [thread overview]
Message-ID: <20060503070811.GC23921@elte.hu> (raw)
In-Reply-To: <16113.1146632636@kao2.melbourne.sgi.com>
* Keith Owens <kaos@sgi.com> wrote:
> KDB just limits kernel traces to a maximum of 200 entries, which
> catches direct as well as indirect recursion. IA64 is notorious for
> getting loops in its unwind data, sometime looping over three or four
> functions. Checking for a maximum number of entries is a simple and
> architecture independent check.
you are right, but in this particular case this doesnt seem to be
'wrong' unwind data, it's more of a special marker of the end of the
frame (if i understood it correctly). If it's wrong unwind data then
that data should be fixed.
I also agree with adding a limit to catch buggy cases of recursion, as a
separate mechanism, independently of this particular bug.
Ingo
prev parent reply other threads:[~2006-05-03 7:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-02 9:50 [patch, 2.6.17-rc3-mm1] i386: break out of recursion in stackframe walk Ingo Molnar
2006-05-03 5:03 ` Keith Owens
2006-05-03 7:08 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060503070811.GC23921@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=kaos@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox