public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Rosenkraenzer <bero@arklinux.org>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org
Subject: [PATCH] 2.6.17-rc3-mm1 breaks AGP on amd64 boxes in 32 bit mode
Date: Thu, 4 May 2006 00:33:33 +0200	[thread overview]
Message-ID: <200605040033.33579.bero@arklinux.org> (raw)

2.6.17-rc3-mm1 breaks AGP on amd64 boxes in 32 bit mode - a change in the 
related Kconfig file forces the agp-amd64 module to be built only on x86_64, 
simply reverting that bit introduces unresolved symbols k8_nb_ids and 
k8_northbridges (defined but not exported).

Signed-off-by: Bernhard Rosenkraenzer <bero@arklinux.org>
---
diff -urNp linux-2.6.16/drivers/char/agp/Kconfig 
linux-2.6.16-driworx/drivers/char/agp/Kconfig
--- linux-2.6.16/drivers/char/agp/Kconfig	2006-05-02 23:30:35.000000000 +0200
+++ linux-2.6.16-driworx/drivers/char/agp/Kconfig	2006-05-02 
22:57:48.000000000 +0200
@@ -56,7 +56,7 @@ config AGP_AMD
 
 config AGP_AMD64
 	tristate "AMD Opteron/Athlon64 on-CPU GART support" if !GART_IOMMU
-	depends on AGP && X86_64
+	depends on AGP && X86
 	default y if GART_IOMMU
 	help
 	  This option gives you AGP support for the GLX component of
--- linux-2.6.16/arch/x86_64/kernel/k8.c.ark	2006-05-03 21:37:35.000000000 
+0200
+++ linux-2.6.16-driworx/arch/x86_64/kernel/k8.c	2006-05-03 21:38:10.000000000 
+0200
@@ -20,8 +20,10 @@ struct pci_device_id k8_nb_ids[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, 0x1203) },
 	{}
 };
+EXPORT_SYMBOL_GPL(k8_nb_ids); // for amd64-agp
 
 struct pci_dev **k8_northbridges;
+EXPORT_SYMBOL_GPL(k8_northbridges); // for amd64-agp
 
 static struct pci_dev *next_k8_northbridge(struct pci_dev *dev)
 {

             reply	other threads:[~2006-05-03 22:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-03 22:33 Bernhard Rosenkraenzer [this message]
2006-05-04  2:36 ` [PATCH] 2.6.17-rc3-mm1 breaks AGP on amd64 boxes in 32 bit mode Andrew Morton
2006-05-04  7:36   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200605040033.33579.bero@arklinux.org \
    --to=bero@arklinux.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox