public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Remove silly messages from input layer.
Date: Wed, 3 May 2006 22:44:04 -0400	[thread overview]
Message-ID: <20060504024404.GA17818@redhat.com> (raw)

There are two messages in the input layer that seem to be
triggerable very easily, and they confuse end-users to no end.
"too many keys pressed? Should I press less keys?"
I actually got a complaint from one user that he had only
hit one key before being told to type less.

The latter message seems to trigger with certain keyboard switchers
and again, does nothing but confuse people.

Best of all, asides from the silly messages, none of the people suffering
them report any other misbehaviour, their keyboards work just fine.

Signed-off-by: Dave Jones <davej@redhat.com>

--- linux-2.6.16.noarch/drivers/input/keyboard/atkbd.c~	2006-05-03 22:37:20.000000000 -0400
+++ linux-2.6.16.noarch/drivers/input/keyboard/atkbd.c	2006-05-03 22:39:58.000000000 -0400
@@ -340,7 +340,6 @@ static irqreturn_t atkbd_interrupt(struc
 			atkbd_report_key(atkbd->dev, regs, KEY_HANJA, 3);
 			goto out;
 		case ATKBD_RET_ERR:
-			printk(KERN_DEBUG "atkbd.c: Keyboard on %s reports too many keys pressed.\n", serio->phys);
 			goto out;
 	}
 
@@ -359,11 +358,7 @@ static irqreturn_t atkbd_interrupt(struc
 		case ATKBD_KEY_NULL:
 			break;
 		case ATKBD_KEY_UNKNOWN:
-			if (data == ATKBD_RET_ACK || data == ATKBD_RET_NAK) {
-				printk(KERN_WARNING "atkbd.c: Spurious %s on %s. Some program, "
-				       "like XFree86, might be trying access hardware directly.\n",
-				       data == ATKBD_RET_ACK ? "ACK" : "NAK", serio->phys);
-			} else {
+			if (data != ATKBD_RET_ACK && data != ATKBD_RET_NAK) {
 				printk(KERN_WARNING "atkbd.c: Unknown key %s "
 				       "(%s set %d, code %#x on %s).\n",
 				       atkbd->release ? "released" : "pressed",

             reply	other threads:[~2006-05-04  2:44 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-04  2:44 Dave Jones [this message]
2006-05-04  7:13 ` Remove silly messages from input layer Pavel Machek
2006-05-04  7:17 ` Pavel Machek
2006-05-04 15:08   ` Martin J. Bligh
2006-05-04 18:34     ` Dmitry Torokhov
2006-05-04 18:38       ` Dave Jones
2006-05-05 10:31         ` Pavel Machek
2006-05-05 10:39           ` Sergei Organov
2006-05-05 10:51             ` Valdis.Kletnieks
2006-05-05 15:27           ` Dave Jones
2006-05-05 15:37             ` Martin Mares
2006-05-05 15:46               ` Dave Jones
2006-05-05 15:54                 ` Martin Mares
2006-05-05 16:00                   ` Dave Jones
2006-05-05 16:12                     ` Martin Mares
2006-05-05 19:59                     ` Nuri Jawad
2006-05-05 20:06                       ` Martin Bligh
2006-05-05 20:30                         ` Nuri Jawad
2006-05-07  8:07                           ` Joseph Fannin
2006-05-08  6:43             ` Helge Hafting
2006-05-08  7:25               ` Con Kolivas
2006-05-09  6:54                 ` Helge Hafting
2006-05-04 19:14       ` Hugh Dickins
2006-05-04 15:45   ` David Greaves
2006-05-06 18:51     ` Jindrich Makovicka
2006-05-04 14:59 ` Nuri Jawad
2006-05-04 19:24   ` Hua Zhong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060504024404.GA17818@redhat.com \
    --to=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox