as bug (was: Re: smp/up alternatives crash when CONFIG_HOTPLUG_CPU)

[Denis Vlasenko <vda@ilport.com.ua>]

[binutils list CC'ed]

On Friday 21 April 2006 10:48, Ingo Molnar wrote:
> you can also try the mutex.bad.s file i attached:
> 
>  $ as mutex.s.bad
>  mutex.s.bad: Assembler messages:
>  mutex.s.bad:267: Warning: .space or .fill with negative value, ignored
>  mutex.s.bad:355: Warning: .space or .fill with negative value, ignored
>  mutex.s.bad:412: Warning: .space or .fill with negative value, ignored
>  mutex.s.bad:574: Warning: .space or .fill with negative value, ignored
>  mutex.s.bad:627: Warning: .space or .fill with negative value, ignored

Reduced testcase, which still exhibits the bug.

# as mutex.bad_minimal.s
mutex.bad_minimal.s: Assembler messages:
mutex.bad_minimal.s:21: Warning: .space or .fill with negative value, ignored
# as --version | head -1
GNU assembler 2.15.91.0.1 20040527
# cat mutex.bad_minimal.s

661:
662:
.section .smp_altinstructions,"a"
  .align 4
  .long 661b
  .byte 0x68
  .byte 662b-661b
.section .smp_altinstr_replacement,"awx"
        .fill 662b-661b,1,0x42
        .section        .sched.text,"ax",@progbits
        call    _spin_unlock    #
661:
2:      jle 2b  #
662:
.section .smp_altinstructions,"a"
  .align 4
  .long 661b
  .byte 0x68
  .byte 662b-661b
.section .smp_altinstr_replacement,"awx"
        .fill 662b-661b,1,0x42

--
vda