From: Joachim Fritschi <jfritschi@freenet.de>
To: linux-kernel@vger.kernel.org
Cc: linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: [RFC][PATCH 2/2] Twofish cipher x86_64-asm optimized
Date: Sun, 7 May 2006 15:33:33 +0200 [thread overview]
Message-ID: <200605071533.33791.jfritschi@freenet.de> (raw)
In-Reply-To: <20060507123353.GA4611@gondor.apana.org.au>
On Sunday 07 May 2006 14:33, Herbert Xu wrote:
> On Sun, May 07, 2006 at 12:38:30PM +0200, Andi Kleen wrote:
> > It would be good if you could run some random input encrypt/decrypt tests
> > comparing the C reference version with yours. We have had bad luck
> > with assembler functions not quite implementing the same cipher
> > in the past.
>
> That's a very good point. The tcrypt module provides both correctness
> tests as well as speed tests for twofish. Please run it with your
> version versus the existing implementation.
All tcrypt tests pass successfully on both architectures.
Here are the outputs from the tcrypt speedtests:
http://homepages.tu-darmstadt.de/~fritschi/twofish/tcrypt-speed-c-i586.txt
http://homepages.tu-darmstadt.de/~fritschi/twofish/tcrypt-speed-asm-i586.txt
http://homepages.tu-darmstadt.de/~fritschi/twofish/tcrypt-speed-c-x86_64.txt
http://homepages.tu-darmstadt.de/~fritschi/twofish/tcrypt-speed-asm-x86_64.txt
Regards,
Joachim
next prev parent reply other threads:[~2006-05-07 13:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-07 9:57 [RFC][PATCH 2/2] Twofish cipher x86_64-asm optimized Joachim Fritschi
2006-05-07 10:38 ` Andi Kleen
2006-05-07 12:33 ` Herbert Xu
2006-05-07 13:33 ` Joachim Fritschi [this message]
2006-05-07 12:47 ` Joachim Fritschi
2006-05-07 20:49 ` Joachim Fritschi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605071533.33791.jfritschi@freenet.de \
--to=jfritschi@freenet.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox