From: Michael Buesch <mb@bu3sch.de>
To: Sergey Vlasov <vsu@altlinux.ru>
Cc: akpm@osdl.org, Deepak Saxena <dsaxena@plexity.net>,
bcm43xx-dev@lists.berlios.de, linux-kernel@vger.kernel.org
Subject: Re: [patch 2/6] New Generic HW RNG
Date: Sun, 7 May 2006 15:56:01 +0200 [thread overview]
Message-ID: <200605071556.01936.mb@bu3sch.de> (raw)
In-Reply-To: <20060507134527.GA14704@procyon.home>
On Sunday 07 May 2006 15:45, you wrote:
> On Sun, May 07, 2006 at 03:27:33PM +0200, Michael Buesch wrote:
> > On Sunday 07 May 2006 15:16, you wrote:
> > > On Sunday 07 May 2006 15:03, you wrote:
> > > > This does not handle the case of partial read correctly - the code
> > > > should be
> > > >
> > > > return ret ? : -ERESTARTSYS;
> >
> > Or, hm. Shouldn't we
> > return ret ? : err;
> >
> > err is -EINTR
>
> -ERESTARTSYS is the proper return code for this case - the signal
> handling code will either convert it to EINTR for userspace, or
> restart the system call after handling the signal, depending on the
> state of the SA_RESTART flag set by sigaction().
Ok, I fixed all your stuff. Thanks.
I will run some more tests now and re-submit, if noone else finds a bug. ;)
--
Greetings Michael.
next prev parent reply other threads:[~2006-05-07 13:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-07 11:35 [patch 0/6] New Generic HW RNG Michael Buesch
2006-05-07 11:35 ` [patch 1/6] " Michael Buesch
2006-05-07 11:35 ` [patch 2/6] " Michael Buesch
2006-05-07 13:03 ` Sergey Vlasov
2006-05-07 13:16 ` Michael Buesch
2006-05-07 13:27 ` Michael Buesch
2006-05-07 13:45 ` Sergey Vlasov
2006-05-07 13:56 ` Michael Buesch [this message]
2006-05-10 20:57 ` Greg KH
2006-05-10 21:18 ` Michael Buesch
2006-05-07 11:35 ` [patch 3/6] " Michael Buesch
2006-05-07 13:09 ` Sergey Vlasov
2006-05-07 14:51 ` Michael Buesch
2006-05-07 11:35 ` [patch 4/6] " Michael Buesch
2006-05-07 11:35 ` [patch 5/6] " Michael Buesch
2006-05-07 11:35 ` [patch 6/6] " Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605071556.01936.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=akpm@osdl.org \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=dsaxena@plexity.net \
--cc=linux-kernel@vger.kernel.org \
--cc=vsu@altlinux.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox