public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Mike Galbraith <efault@gmx.de>, Andi Kleen <ak@suse.de>,
	Christopher Friesen <cfriesen@nortel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: sched_clock() uses are broken
Date: Sun, 7 May 2006 17:53:56 +0100	[thread overview]
Message-ID: <20060507165356.GA32453@flint.arm.linux.org.uk> (raw)
In-Reply-To: <445DF667.309@yahoo.com.au>

On Sun, May 07, 2006 at 11:30:15PM +1000, Nick Piggin wrote:
> Russell King wrote:
> >On Sun, May 07, 2006 at 11:00:29PM +1000, Nick Piggin wrote:
> >
> >>Nick Piggin wrote:
> >>
> >>
> >>>I stand by my first reply to your comment WRT the API.
> >>
> >>Actually, on rereading, it seems like I was a bit confused about
> >>your proposal. I don't think you specified anyway the units
> >>returned by your new sched_clock(). So it is identical to my
> >>"corrected" interface :\
> >
> >
> >Okay, so that presumably means we have to either stick with what we
> >currently have, or go the whole hog and re-implement the sched_clock()
> >support?
> >
> >IOW, my patch on 2nd May isn't of any use as it currently stands?
> 
> IMO it would probably be best to try to re implement it in one go.
> It shouldn't have spread too far out of kernel/sched.c, and the arch
> code should mostly be implementable in terms of their sched_clock().
> Mundane but not difficult.

Having looked at this several times over the last couple of days, I've
come to the conclusion that I'm not the right person to fix this problem.
I've tried several methods of converting the code, but every time I
remain unconvinced that the changes are provably correct as far as not
missing something, so I end up throwing the changes away and starting
again.

Yes, I admit defeat.

Maybe someone who cares about this stuff[1] (or who sees the problem)
should look into it.

[1] - eg, the original poster on linux-arm-kernel who indirectly pointed
out the sched_clock() issue.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

  parent reply	other threads:[~2006-05-07 16:54 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-02 13:29 sched_clock() uses are broken Russell King
2006-05-02 14:21 ` Nick Piggin
2006-05-02 16:43 ` Andi Kleen
2006-05-02 16:50   ` Russell King
2006-05-02 17:01     ` Andi Kleen
2006-05-02 17:18       ` Nicolas Pitre
2006-05-02 18:55         ` Russell King
2006-05-02 19:05           ` Nicolas Pitre
2006-05-02 19:08             ` Russell King
2006-05-02 19:23               ` Nicolas Pitre
2006-05-02 21:35                 ` Russell King
2006-05-02 17:15     ` Nicolas Pitre
2006-05-04  3:50       ` George Anzinger
2006-05-04 14:18         ` Nicolas Pitre
2006-05-02 16:54   ` Christopher Friesen
2006-05-02 16:59     ` Andi Kleen
2006-05-02 17:07       ` Nick Piggin
2006-05-03  7:09         ` Mike Galbraith
2006-05-03  7:40           ` Andi Kleen
2006-05-03  9:11             ` Mike Galbraith
2006-05-03  9:16               ` Andi Kleen
2006-05-03  9:31                 ` Mike Galbraith
2006-05-07 12:33           ` Nick Piggin
2006-05-07 12:43             ` Russell King
2006-05-07 12:56               ` Nick Piggin
2006-05-07 13:00                 ` Nick Piggin
2006-05-07 13:18                   ` Russell King
2006-05-07 13:30                     ` Nick Piggin
2006-05-07 13:55                       ` Russell King
2006-05-07 14:04                         ` Nick Piggin
2006-05-07 16:03                           ` Andi Kleen
2006-05-07 16:53                       ` Russell King [this message]
2006-05-07 17:52                         ` Mike Galbraith
2006-05-07 17:37               ` Mike Galbraith
2006-05-07 17:32             ` Mike Galbraith
2006-05-08  4:14               ` Mike Galbraith
2006-05-08  4:37                 ` Mike Galbraith
2006-05-08  4:46                   ` Nick Piggin
2006-05-08  5:24                     ` Mike Galbraith
2006-05-08  5:30                       ` Nick Piggin
2006-05-04 20:02 ` Florian Paul Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060507165356.GA32453@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=ak@suse.de \
    --cc=cfriesen@nortel.com \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox