Re: [PATCH] s390: Hypervisor File System

[Greg KH <greg@kroah.com>]

On Mon, May 08, 2006 at 02:24:16PM +0200, Michael Holzheu wrote:
> Hi Greg,
> 
> Greg KH <greg@kroah.com> wrote on 05/05/2006 11:14:47 PM:
> > > I added a invisible config option CONFIG_SYS_HYPERVISOR. If this
> > > option is enabled, /sys/hypervisor is created. CONFIG_S390_HYPFS
> > > enables this option automatically using "select".
> > > 
> > > This the following patch acceptable for you?
> 
> Ok, I modified the patch according to your input. So
> hopefully that's the final one... ok?

It is so close...

> diff -urpN linux-2.6.16/drivers/base/base.h linux-2.6.16-hypervisor/drivers/base/base.h
> --- linux-2.6.16/drivers/base/base.h	2006-03-20 06:53:29.000000000 +0100
> +++ linux-2.6.16-hypervisor/drivers/base/base.h	2006-05-08 14:13:18.000000000 +0200
> @@ -5,6 +5,11 @@ extern int devices_init(void);
>  extern int buses_init(void);
>  extern int classes_init(void);
>  extern int firmware_init(void);
> +#ifdef CONFIG_SYS_HYPERVISOR
> +extern int hypervisor_init(void);
> +#else
> +#define hypervisor_init() do { } while(0)
> +#endif

Hm, that second case there doesn't return anything incase we actually
try to check the return value of hypervisor_init()...

Other than that, looks good.  Care to fix this and send it again with a
real changelog and Signed-off-by: line, and I'll be glad to add it to my
tree.

thanks,

greg k-h