public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Balbir Singh <balbir@in.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: lse-tech@lists.sourceforge.net, akpm@osdl.org
Subject: [PATCH][delayacct] Use portable cputime API in __delayacct_add_tsk()
Date: Wed, 10 May 2006 17:36:58 +0530	[thread overview]
Message-ID: <20060510120658.GA16239@in.ibm.com> (raw)

Hi, Andrew,

While testing on ppc64, I found that taskstats could return incorrect data.
The same code worked fine on x86.

	Thanks,
	Balbir Singh,
	Linux Technology Center,
	IBM Software Labs


Description of the patch
------------------------

tsk->utime and tsk->stime are of type cputime_t. Explicitly converting from
cputime to nanoseconds does not work on all platforms. Use the cputime
API for conversion. This makes the code more portable and returns correct data
on ppc64.

This patch has been tested on x86 and ppc64.

Signed-off-by: Balbir Singh <balbir@in.ibm.com>
---

 kernel/delayacct.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

diff -puN kernel/delayacct.c~taskstats-use-cputime-api-for-cpu_run_real_time kernel/delayacct.c
--- linux-2.6.17-rc3/kernel/delayacct.c~taskstats-use-cputime-api-for-cpu_run_real_time	2006-05-10 17:04:22.000000000 +0530
+++ linux-2.6.17-rc3-balbir/kernel/delayacct.c	2006-05-10 17:05:45.000000000 +0530
@@ -112,7 +112,8 @@ int __delayacct_add_tsk(struct taskstats
 	unsigned long t1,t2,t3;
 
 	tmp = (s64)d->cpu_run_real_total;
-	tmp += (u64)(tsk->utime + tsk->stime) * TICK_NSEC;
+	cputime_to_timespec(tsk->utime + tsk->stime, &ts);
+	tmp += timespec_to_ns(&ts);
 	d->cpu_run_real_total = (tmp < (s64)d->cpu_run_real_total) ? 0 : tmp;
 
 	/*
_

                 reply	other threads:[~2006-05-10 12:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060510120658.GA16239@in.ibm.com \
    --to=balbir@in.ibm.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lse-tech@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox