Re: [PATCH -mm] sys_semctl gcc 4.1 warning fix

Daniel Walker
2006-05-10T15:06:40Z

On Wed, 2006-05-10 at 16:09 +0100, Alan Cox wrote:
> On Mer, 2006-05-10 at 07:31 -0700, Daniel Walker wrote:
> > > Hiding warnings like this can be a hazard as it will hide real warnings
> > > later on.
> >
> > How could it hide real warnings? If anything these patch allow other
> > (real warnings) to be seen .
>
> Because while the warning is present people will check it now and again.

But it's pointless to review it, in this case and for this warning .

> If you set the variable to zero then you generate extra code and you
> ensure nobody will look in future.

The extra code is a problem , I'll admit that . But the warning should
disappear , it's just a waste .

Daniel