Re: [PATCH -mm] sys_semctl gcc 4.1 warning fix

Adrian Bunk
2006-05-10T20:36:21Z

On Wed, May 10, 2006 at 10:24:01PM +0200, Adrian Bunk wrote:
> On Wed, May 10, 2006 at 01:45:58PM -0400, Steven Rostedt wrote:
> >
> > Oh fsck! gcc is hosed. I just tried out this BS module:
> >...
> > And this is what I got!
> >
> > CC [M] /home/rostedt/c/modules/warning.o
> > /home/rostedt/c/modules/warning.c: In function 'warn_here':
> > /home/rostedt/c/modules/warning.c:14: warning: 'x' is used uninitialized in this function
> > Building modules, stage 2.
> >
> >
> > Why the fsck isn't the func but_not_here not getting a warning for the
> > first use of printk?? If I remove the if statement it gives me the
> > warning. Hell, that if statement isn't even entered (g = 0).
> >...
>
> I can't reproduce this, gcc 4.1 gives me:
>
> CC [M] init/test.o
> init/test.c: In function 'warn_here':
> init/test.c:14: warning: 'x' is used uninitialized in this function
> init/test.c: In function 'but_not_here':
> init/test.c:23: warning: 'y' is used uninitialized in this function

Same with gcc 4.0.

I can reproduce your problem only with gcc 3.3 and gcc 3.4.

Can we please discuss issues in current gcc releases instead of gcc
bashing ("Oh fsck! gcc is hosed.") based on issues no longer present in
the latest two major releases of gcc?

TIA
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed