From: Al Viro <viro@ftp.linux.org.uk>
To: Daniel Walker <dwalker@mvista.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Adrian Bunk <bunk@stusta.de>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] sys_semctl gcc 4.1 warning fix
Date: Wed, 10 May 2006 22:39:29 +0100 [thread overview]
Message-ID: <20060510213929.GF27946@ftp.linux.org.uk> (raw)
In-Reply-To: <1147296822.21536.175.camel@c-67-180-134-207.hsd1.ca.comcast.net>
On Wed, May 10, 2006 at 02:33:42PM -0700, Daniel Walker wrote:
> > Consider the following scenario:
> >
> > 1) gcc gives false positive
> > 2) tosser on a rampage "fixes" it
> > 3) code is chaged a month later
> > 4) a real bug is introduced - one that would be _really_ visible to gcc,
> > with "is used" in a warning
> > 5) thanks to aforementioned tosser, that bug remains hidden.
>
> I don't really see anything new here .. The same sort of stuff can
> happen in any code considered for inclusion .. That's what the review
> process is for .
>
> Real errors can be covered up any number of way ..
One last time: your kind of patches actually increases the odds of new bug
staying unnoticed.
If you really fill the urge to pull a Bunk, do it somewhere else, please -
the real thing is already more than sufficiently annoying.
next prev parent reply other threads:[~2006-05-10 21:39 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-10 2:56 [PATCH -mm] sys_semctl gcc 4.1 warning fix Daniel Walker
2006-05-10 10:34 ` Alan Cox
2006-05-10 14:31 ` Daniel Walker
2006-05-10 15:09 ` Alan Cox
2006-05-10 15:06 ` Daniel Walker
2006-05-10 15:24 ` Steven Rostedt
2006-05-10 16:24 ` Adrian Bunk
2006-05-10 17:18 ` Steven Rostedt
2006-05-10 17:45 ` Steven Rostedt
2006-05-10 18:27 ` Stephen Hemminger
2006-05-10 19:07 ` Serge Belyshev
2006-05-10 20:24 ` Adrian Bunk
2006-05-10 20:35 ` Steven Rostedt
2006-05-10 20:36 ` Adrian Bunk
2006-05-10 20:53 ` Steven Rostedt
2006-05-10 19:20 ` Steven Rostedt
2006-05-10 19:49 ` Daniel Walker
2006-05-10 20:44 ` Steven Rostedt
2006-05-10 21:11 ` Daniel Walker
2006-05-10 21:20 ` Al Viro
2006-05-10 21:33 ` Daniel Walker
2006-05-10 21:39 ` Al Viro [this message]
2006-05-10 21:45 ` Daniel Walker
2006-05-10 21:48 ` Al Viro
2006-05-11 6:36 ` Steven Rostedt
2006-05-10 15:39 ` Alan Cox
2006-05-10 15:38 ` Daniel Walker
2006-05-10 16:21 ` Al Viro
2006-05-10 16:37 ` Daniel Walker
2006-05-10 16:42 ` Al Viro
2006-05-10 17:25 ` Daniel Walker
2006-05-10 19:55 ` Alistair John Strachan
2006-05-10 22:03 ` Andrew Morton
2006-05-10 22:10 ` Al Viro
2006-05-10 22:31 ` David S. Miller
2006-05-10 22:45 ` Al Viro
2006-05-10 23:05 ` Andrew Morton
2006-05-10 23:20 ` Al Viro
2006-05-10 23:45 ` Andrew Morton
2006-05-11 1:28 ` Al Viro
2006-05-11 8:11 ` Steven Rostedt
2006-05-11 10:07 ` [PATCH -mm] introduce a false positive macro Steven Rostedt
2006-05-11 20:40 ` [PATCH -mm] sys_semctl gcc 4.1 warning fix Adrian Bunk
2006-05-11 21:14 ` Al Viro
2006-05-10 23:06 ` Roland Dreier
2006-05-10 22:30 ` David S. Miller
2006-05-11 2:58 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060510213929.GF27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bunk@stusta.de \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox