Re: [RFC PATCH 16/35] subarch support for interrupt and exception gates

Chris Wright
2006-05-15T18:27:31Z

* Andrew Morton (akpm@osdl.org) wrote:
> On Tue, 09 May 2006 00:00:16 -0700
> Chris Wright <chrisw@sous-sol.org> wrote:
>
> > --- linus-2.6.orig/include/asm-i386/mach-xen/setup_arch_pre.h
> > +++ linus-2.6/include/asm-i386/mach-xen/setup_arch_pre.h
> > @@ -5,6 +5,8 @@
> > struct start_info *xen_start_info;
> > EXPORT_SYMBOL(xen_start_info);
> >
> > +struct trap_info xen_trap_table[257];
> > +
> > /*
> > * Point at the empty zero page to start with. We map the real shared_info
> > * page as soon as fixmap is up and running.
>
> Is there any particular reason why things-which-should-be-in-a-C-file are
> present in a .h file?

It's following direction of current subarch interaction with setup.c
(namely the setup_arch_post.h). It's definitely not so nice.