Re: [RFC PATCH 29/35] Add the Xen virtual console driver.

Nick Piggin
2006-05-13T12:51:17Z

Andrew Morton wrote:

>>+static void kcons_write_dom0(
>>+ struct console *c, const char *s, unsigned int count)
>>+{
>>+ int rc;
>>+
>>+ while ((count > 0) &&
>>+ ((rc = HYPERVISOR_console_io(
>>+ CONSOLEIO_write, count, (char *)s)) > 0)) {
>>+ count -= rc;
>>+ s += rc;
>>+ }
>>+}
>
>
> must.. not.. mention.. coding.. style..

Someone should write you a script to go through a patch and flag the
most common style mistakes. Have the output formatted to look like
you're replying to the mail, and wire it up to your inbox ;)

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com