Re: [RFC PATCH 15/35] subarch support for controlling interrupt delivery

Nick Piggin
2006-05-09T19:23:26Z

Martin J. Bligh wrote:
>> +/*
>> + * The use of 'barrier' in the following reflects their use as
>> local-lock
>> + * operations. Reentrancy must be prevented (e.g., __cli()) /before/
>> following
>> + * critical operations are executed. All critical operations must
>> complete
>> + * /before/ reentrancy is permitted (e.g., __sti()). Alpha
>> architecture also
>> + * includes these barriers, for example.
>> + */
>
>
> Seems like an odd comment to have in an i386 header file.

Also, it is only talking about compiler barriers, which have nothing
to do with the architecture.

And preempt_* macros should contain the correct compiler barriers, so
several can be removed.

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com