Re: [Xen-devel] [RFC PATCH 34/35] Add the Xen virtual network device driver.

Keir Fraser
2006-05-10T06:41:22Z

On 10 May 2006, at 00:51, Chris Wright wrote:

> * Herbert Xu (herbert@gondor.apana.org.au) wrote:
>> Chris Wright <chrisw@sous-sol.org> wrote:
>>>
>>> + netdev->features = NETIF_F_IP_CSUM;
>>
>> Any reason why IP_CSUM was chosen instead of HW_CSUM? Doing the latter
>> would seem to be in fact easier for a virtual driver, no?
>
> That, I really don't know.

Checksum offload was added late to the virtual transport and currently
not enough info is carried to identify protocol checksum fields in
arbitrary locations. When we rev the virtual interface, and include a
proper checksum-offset field, we'll be able to switch to
NETIF_F_HW_CSUM.

-- Keir