Re: [RFC PATCH 29/35] Add the Xen virtual console driver.

Christian Limpach
2006-05-09T15:03:51Z

On Tue, May 09, 2006 at 03:26:10PM +0200, Andi Kleen wrote:
>
> > --- linus-2.6.orig/drivers/char/tty_io.c
> > +++ linus-2.6/drivers/char/tty_io.c
> > @@ -132,6 +132,8 @@ LIST_HEAD(tty_drivers); /* linked list
> > vt.c for deeply disgusting hack reasons */
> > DEFINE_MUTEX(tty_mutex);
> >
> > +int console_use_vt = 1;
> > +
>
> Can you explain why this variable is needed? It shouldn't. If you only
> register your console as the primary console nothing else should
> be printed.

It is needed for having a kernel which can run both as a dom0 and domU
kernel. For dom0, you want to build with CONFIG_VT enabled while for
domU, the CONFIG_VT code doesn't let the xen console be the primary
console unless you specify it on the command line.

I've removed this from the patchqueue since a kernel built from the
patchqueue won't run as a dom0 kernel anyway.

> > +/*** Useful function for console debugging -- goes straight to Xen. ***/
> > +asmlinkage int xprintk(const char *fmt, ...)
>
> This is called early_printk in the rest of i386. Please use that name too.

We have proper early_printk support but it's not part of the patchqueue.
This is more of a debug function where you would rename the kernel/printk
to something else and rename this to printk. I've removed it.

christian