Re: [RFC PATCH 03/35] Add Xen interface header files

Christoph Hellwig
2006-05-09T15:15:19Z

> Signed-off-by: Christian Limpach <Christian.Limpach@cl.cam.ac.uk>
> Signed-off-by: Chris Wright <chrisw@sous-sol.org>
> ---
> include/xen/interface/arch-x86_32.h | 197 +++++++++++++++

that kind of stuff needs to go to asm/

> include/xen/interface/event_channel.h | 205 +++++++++++++++

instead of interface please use something shorter, we'll see this
all over the includes statements. intf for example.

> +#ifdef __XEN__
> +#define __DEFINE_GUEST_HANDLE(name, type) \
> + typedef struct { type *p; } __guest_handle_ ## name
> +#else
> +#define __DEFINE_GUEST_HANDLE(name, type) \
> + typedef type * __guest_handle_ ## name
> +#endif

please get rid of all these stupid typedefs

> +#ifndef __ASSEMBLY__
> +/* Guest handles for primitive C types. */
> +__DEFINE_GUEST_HANDLE(uchar, unsigned char);
> +__DEFINE_GUEST_HANDLE(uint, unsigned int);
> +__DEFINE_GUEST_HANDLE(ulong, unsigned long);

don't use uchar/uint/ulong types ever. And in things like
hypervisor/kernel interfaces always use __u* types.