Re: [RFC PATCH 03/35] Add Xen interface header files

Christian Limpach
2006-05-09T16:18:59Z

On Tue, May 09, 2006 at 09:06:12AM -0700, Daniel Walker wrote:
> On Tue, 2006-05-09 at 00:00 -0700, Chris Wright wrote:
> > plain text document attachment (xen-interface-headers)
> > Add Xen interface header files. These are taken fairly directly from
> > the Xen tree and hence the style is not entirely in accordance with
> > Linux guidelines. There is a tension between fitting with Linux coding
> > rules and ease of maintenance.
> >
> > Signed-off-by: Ian Pratt <ian.pratt@xensource.com>
> > Signed-off-by: Christian Limpach <Christian.Limpach@cl.cam.ac.uk>
> > Signed-off-by: Chris Wright <chrisw@sous-sol.org>
> > ---
> > include/xen/interface/arch-x86_32.h | 197 +++++++++++++++
> > include/xen/interface/event_channel.h | 205 +++++++++++++++
> > include/xen/interface/features.h | 53 ++++
> > include/xen/interface/grant_table.h | 311 +++++++++++++++++++++++
> > include/xen/interface/io/blkif.h | 85 ++++++
>
> Shouldn't these be under asm-i386 , or are they used by other
> architecture ?

The full set of interface headers supports several architectures.

I think having all the header files in one place is preferable,
but will gladly move them wherever is agreed on to be best ;-)

christian