Re: [Xen-devel] Re: [RFC PATCH 07/35] Make LOAD_OFFSET defined by subarch

Gerd Hoffmann
2006-05-11T09:04:19Z

Chris Wright wrote:
> * Gerd Hoffmann (kraxel@suse.de) wrote:
>> I fully agree. Attached below is a patch (against xen unstable
>> mercurial tree) which does exactly that ;)
>
> Thanks Gerd, I thought you had been working on that. Was the concern
> with vaddr vs. paddr worked out?

Not yet, and I didn't feel comfortable pushing it just before the 3.0.2
release, but I think _now_ would be a good time to finally merge it.
Having physical addresses in paddr seems to be common practice, and IMO
xen should follow that as it makes life easier for everybody.

It's not a big problem that xen guests boot with paging enabled, and as
Zachary already pointed out it's trivial to use virt_base from the
xen_guest elf section to create correct initial page tables.

Even maintaining backward compatibility with some guesswork is possible
as it is _very_ unlikely that the paddr field holds physical addresses
larger than virt_base ;)

cheers,

Gerd

--
Gerd Hoffmann <kraxel@suse.de>
Erst mal heiraten, ein, zwei Kinder, und wenn alles läuft
geh' ich nach drei Jahren mit der Familie an die Börse.