From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Erik Mouw <erik@harddisk-recovery.com>,
Or Gerlitz <or.gerlitz@gmail.com>,
linux-scsi@vger.kernel.org, axboe@suse.de,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BUG 2.6.17-git] kmem_cache_create: duplicate cache scsi_cmd_cache
Date: Fri, 12 May 2006 21:34:16 +0100 [thread overview]
Message-ID: <20060512203416.GA17120@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0605121024310.3866@g5.osdl.org>
On Fri, May 12, 2006 at 10:36:57AM -0700, Linus Torvalds wrote:
> Yes. We could just revert that commit, but it seems correct, and I'd
> really like for somebody to understand _why_ that commit matters at all. I
> certainly don't see the overlap here..
Reverting the commit breaks MMC/SD in a very real way, and the fix
is plainly correct and is actually the only possible fix that can be
applied.
It sounds to me like SCSI is relying on some buggy behaviour which is
specific to the way that the kernel works with the fix removed. Maybe
thing is kfree'ing and then reallocating something which remained
registered somewhere when it shouldn't do?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2006-05-12 20:34 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060511151456.GD3755@harddisk-recovery.com>
[not found] ` <15ddcffd0605112153q57f139a1k7068e204a3eeaf1f@mail.gmail.com>
2006-05-12 17:16 ` [BUG 2.6.17-git] kmem_cache_create: duplicate cache scsi_cmd_cache Erik Mouw
2006-05-12 17:27 ` Andrew Vasquez
2006-05-12 20:18 ` Erik Mouw
2006-05-12 17:36 ` Linus Torvalds
2006-05-12 17:47 ` James Bottomley
2006-05-12 18:58 ` James Bottomley
2006-05-12 19:09 ` Linus Torvalds
2006-05-12 20:38 ` Russell King
2006-05-12 20:50 ` Linus Torvalds
2006-05-12 20:58 ` Russell King
2006-05-12 21:27 ` Linus Torvalds
2006-05-12 21:46 ` Linus Torvalds
2006-05-12 21:51 ` Russell King
2006-05-12 22:15 ` Linus Torvalds
2006-05-12 22:37 ` Linus Torvalds
2006-05-12 23:57 ` Greg KH
2006-05-14 16:01 ` Russell King
2006-05-12 21:18 ` Greg KH
2006-05-12 21:32 ` Linus Torvalds
2006-05-12 22:45 ` Greg KH
2006-05-12 20:52 ` Greg KH
2006-05-12 21:03 ` Russell King
2006-05-12 21:34 ` Greg KH
2006-05-12 21:39 ` Al Viro
2006-05-12 20:30 ` Erik Mouw
2006-05-12 20:37 ` Russell King
2006-05-12 20:21 ` Erik Mouw
2006-05-12 20:34 ` Russell King [this message]
2006-05-12 21:43 ` Al Viro
2006-05-12 21:55 ` Russell King
2006-05-12 22:08 ` Al Viro
2006-05-12 22:22 ` Linus Torvalds
2006-05-12 22:28 ` Al Viro
2006-05-12 22:48 ` Al Viro
2006-05-12 22:51 ` Al Viro
2006-05-12 23:04 ` Linus Torvalds
2006-05-12 23:21 ` Al Viro
2006-05-12 23:37 ` Al Viro
2006-05-12 23:50 ` Linus Torvalds
2006-05-13 0:20 ` Al Viro
2006-05-24 14:07 ` Erik Mouw
2006-05-13 0:08 ` Greg KH
2006-05-12 22:37 ` Russell King
2006-05-12 21:58 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060512203416.GA17120@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=axboe@suse.de \
--cc=erik@harddisk-recovery.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox