public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Al Viro <viro@ftp.linux.org.uk>,
	Erik Mouw <erik@harddisk-recovery.com>,
	Or Gerlitz <or.gerlitz@gmail.com>,
	linux-scsi@vger.kernel.org, axboe@suse.de,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BUG 2.6.17-git] kmem_cache_create: duplicate cache scsi_cmd_cache
Date: Fri, 12 May 2006 23:37:56 +0100	[thread overview]
Message-ID: <20060512223755.GJ17120@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0605121519420.3866@g5.osdl.org>

On Fri, May 12, 2006 at 03:22:42PM -0700, Linus Torvalds wrote:
> On Fri, 12 May 2006, Al Viro wrote:
> > Secondary question: who had resurrected that crap?  I distinctly remember
> > killing it off...
> 
> If you did, I don't think it ever got into the kernel.
> 
> It was added by Kay Sievers on Nov 3, 2004, according to the old history 
> (back then it was in drivers/block/genhd.c, and the function was called 
> "block_hotplug()", but apart from renaming the function and moving the 
> file, it's recognizably the same.
> 
> Of course, you may have killed off an even earlier incarnation..

The changes in question are:

commit fa675765afed59bb89adba3369094ebd428b930b
tree 777a8c1bb48ef7de39073104f974209f4a462b6f
parent b00dc3ad74fdb676552d46ee573b88e927240d0c
author Greg Kroah-Hartman <gregkh@suse.de> Wed, 22 Feb 2006 09:39:02 -0800
committer Greg Kroah-Hartman <gregkh@suse.de> Wed, 22 Feb 2006 09:39:02 -0800

    Revert mount/umount uevent removal

    This change reverts the 033b96fd30db52a710d97b06f87d16fc59fee0f1 commit
    from Kay Sievers that removed the mount/umount uevents from the kernel.
    Some older versions of HAL still depend on these events to detect when a
    new device has been mounted.  These events are not correctly emitted,
    and are broken by design, and so, should not be relied upon by any
    future program.  Instead, the /proc/mounts file should be polled to
    properly detect this kind of event.

    A feature-removal-schedule.txt entry has been added, noting when this
    interface will be removed from the kernel.

    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

commit 033b96fd30db52a710d97b06f87d16fc59fee0f1
tree 00fbccf2cf478307e213f298a221e330f3ba12ae
parent 0f76e5acf9dc788e664056dda1e461f0bec93948
author Kay Sievers <kay.sievers@suse.de> 1131685795 +0100
committer Greg Kroah-Hartman <gregkh@suse.de> 1136420287 -0800

    [PATCH] remove mount/umount uevents from superblock handling

    The names of these events have been confusing from the beginning
    on, as they have been more like claim/release events. We needed these
    events for noticing HAL if storage devices have been mounted.

    Thanks to Al, we have the proper solution now and can poll()
    /proc/mounts instead to get notfied about mount tree changes.

    Signed-off-by: Kay Sievers <kay.sievers@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>


-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

  parent reply	other threads:[~2006-05-12 22:38 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060511151456.GD3755@harddisk-recovery.com>
     [not found] ` <15ddcffd0605112153q57f139a1k7068e204a3eeaf1f@mail.gmail.com>
2006-05-12 17:16   ` [BUG 2.6.17-git] kmem_cache_create: duplicate cache scsi_cmd_cache Erik Mouw
2006-05-12 17:27     ` Andrew Vasquez
2006-05-12 20:18       ` Erik Mouw
2006-05-12 17:36     ` Linus Torvalds
2006-05-12 17:47       ` James Bottomley
2006-05-12 18:58         ` James Bottomley
2006-05-12 19:09           ` Linus Torvalds
2006-05-12 20:38             ` Russell King
2006-05-12 20:50               ` Linus Torvalds
2006-05-12 20:58                 ` Russell King
2006-05-12 21:27                   ` Linus Torvalds
2006-05-12 21:46                     ` Linus Torvalds
2006-05-12 21:51                     ` Russell King
2006-05-12 22:15                       ` Linus Torvalds
2006-05-12 22:37                         ` Linus Torvalds
2006-05-12 23:57                           ` Greg KH
2006-05-14 16:01                             ` Russell King
2006-05-12 21:18                 ` Greg KH
2006-05-12 21:32                   ` Linus Torvalds
2006-05-12 22:45                     ` Greg KH
2006-05-12 20:52               ` Greg KH
2006-05-12 21:03                 ` Russell King
2006-05-12 21:34                   ` Greg KH
2006-05-12 21:39                   ` Al Viro
2006-05-12 20:30           ` Erik Mouw
2006-05-12 20:37           ` Russell King
2006-05-12 20:21       ` Erik Mouw
2006-05-12 20:34       ` Russell King
2006-05-12 21:43         ` Al Viro
2006-05-12 21:55           ` Russell King
2006-05-12 22:08             ` Al Viro
2006-05-12 22:22               ` Linus Torvalds
2006-05-12 22:28                 ` Al Viro
2006-05-12 22:48                   ` Al Viro
2006-05-12 22:51                     ` Al Viro
2006-05-12 23:04                       ` Linus Torvalds
2006-05-12 23:21                         ` Al Viro
2006-05-12 23:37                           ` Al Viro
2006-05-12 23:50                             ` Linus Torvalds
2006-05-13  0:20                               ` Al Viro
2006-05-24 14:07                               ` Erik Mouw
2006-05-13  0:08                   ` Greg KH
2006-05-12 22:37                 ` Russell King [this message]
2006-05-12 21:58           ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060512223755.GJ17120@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=axboe@suse.de \
    --cc=erik@harddisk-recovery.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=or.gerlitz@gmail.com \
    --cc=torvalds@osdl.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox