From: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
linux-kernel@vger.kernel.org, ak@suse.de
Subject: Re: [PATCH] i386/x86-64 Add nmi watchdog support for new Intel CPUs
Date: Sun, 14 May 2006 20:03:01 -0700 [thread overview]
Message-ID: <20060514200301.A16957@unix-os.sc.intel.com> (raw)
In-Reply-To: <20060514191101.45982cc0.akpm@osdl.org>; from akpm@osdl.org on Sun, May 14, 2006 at 07:11:01PM -0700
On Sun, May 14, 2006 at 07:11:01PM -0700, Andrew Morton wrote:
> Venkatesh Pallipadi <venkatesh.pallipadi@intel.com> wrote:
> >
> > --- linux-2.6.17-rc4/arch/i386/kernel/nmi.c 2006-05-11 17:23:13.000000000 -0700
> > +++ linux-2.6.17-rc4-nmi/arch/i386/kernel/nmi.c 2006-05-12 17:47:48.000000000 -0700
> >
> > ...
> >
> > +static void disable_intel_arch_watchdog(void)
>
> Should this code be moved to arch/i386/kernel/cpu/intel.c?
I am not sure. The other watchdog setup functions p3, p4, k7 are all
in nmi.c file and thats the reason I kept the new function in the same file too.
Also, as this is specific to watchdog event, it won't be called by anyone else.
If you are thinking of putting these disable and enable functions in same place so
that we can share it across i386/x86_64, we can put it in intel_cacheinfo or create
a new file for this. There is one line difference between i386 and x86_64 enable
functions due to a macro getting used in i386 version. So, we will have to workaround
that to make this code shared.
Thanks,
Venki
next prev parent reply other threads:[~2006-05-15 3:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-15 1:50 [PATCH] i386/x86-64 Add nmi watchdog support for new Intel CPUs Venkatesh Pallipadi
2006-05-15 2:11 ` Andrew Morton
2006-05-15 3:03 ` Venkatesh Pallipadi [this message]
2006-05-15 7:22 ` Andi Kleen
2006-05-25 22:54 ` Venkatesh Pallipadi
2006-05-26 7:34 ` Andi Kleen
2006-06-23 12:35 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060514200301.A16957@unix-os.sc.intel.com \
--to=venkatesh.pallipadi@intel.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox