Re: [patch 03/11] input: new force feedback interface

Anssi Hannula
2006-05-24T10:45:17Z

Anssi Hannula wrote:
> Andrew Morton wrote:
>
>>Anssi Hannula <anssi.hannula@gmail.com> wrote:
>>
>>
>>>Implement a new force feedback interface, in which all non-driver-specific
>>>operations are separated to a common module. This module handles effect type
>>>validations, effect timers, locking, etc.
>>>
>>>As a result, support is added for gain and envelope for memoryless devices,
>>>periodic => rumble conversion for memoryless devices and rumble => periodic
>>>conversion for devices with periodic support instead of rumble support. Also
>>>the effect memory of devices is not emptied if the root user opens and closes
>>>the device while another user is using effects. This module also obsoletes
>>>some flawed locking and timer code in few ff drivers.
>>>
>>>The module is named ff-effects. If INPUT_FF_EFFECTS is enabled, the force
>>>feedback drivers and interfaces (evdev) will be depending on it.
>>>
>>>Userspace interface is left unaltered.
>>>
>>
>>
>>Nice-looking patches.
>>
>
>
> Thanks for looking and providing helpful comments :)
>

Andrew, did you get my response? I received Delivery Status Notification
for your address:
<copy>
- These recipients of your message have been processed by the mail server:
akpm@osdl.org; Failed; 5.3.0 (other or undefined mail system status)

Remote MTA smtp.osdl.org: network error

- SMTP protocol diagnostic: 554 5.7.1 gmail.com suggested we reject
your email: 81.228.11.120 is neither permitted nor denied by domain of
anssi.hannula@gmail.com
</paste>

>
> BTW, what is the best way to send corrected patches for this patchset?
> Probably as a reply to the individual patches?
>

Hmm, I think it is easier to just send the whole updated set...

I'm going to do all the changes discussed and then send the set probably
tomorrow or in the weekend.