Re: [patch 03/11] input: new force feedback interface

Andrew Morton
2006-05-25T00:49:41Z

Anssi Hannula <anssi.hannula@gmail.com> wrote:
>
>
> Andrew, did you get my response?

Nope.

> I received Delivery Status Notification
> for your address:
> <copy>
> - These recipients of your message have been processed by the mail server:
> akpm@osdl.org; Failed; 5.3.0 (other or undefined mail system status)
>
> Remote MTA smtp.osdl.org: network error
>
>
> - SMTP protocol diagnostic: 554 5.7.1 gmail.com suggested we reject
> your email: 81.228.11.120 is neither permitted nor denied by domain of
> anssi.hannula@gmail.com
> </paste>
>

Appropriate people have been informed ;)

>
> >
> > BTW, what is the best way to send corrected patches for this patchset?
> > Probably as a reply to the individual patches?
> >
>
> Hmm, I think it is easier to just send the whole updated set...
>
> I'm going to do all the changes discussed and then send the set probably
> tomorrow or in the weekend.
>

Yes, that's fine. Once patches have matured a bit, incremental (and
fine-grained) updates are preferred. And I'll often turn
wholesale-replacement-attempts into incremental updates, so we can see what
changed.

But at this stage, rip-it-out-and-redo is fine. Although it does help if
you can tell us which of the review comments were and were not implemented,
so we don't have to re-read the whole thing with the same level of
attention.