From: Jesper Juhl <jesper.juhl@gmail.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, Frederic Rible <frible@teaser.fr>,
Jean-Paul Roubelat <jpr@f6fbb.org>,
linux-hams@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
Jesper Juhl <jesper.juhl@gmail.com>
Subject: Re: [PATCH] fix potential NULL pointer dereference in yam
Date: Mon, 15 May 2006 22:19:36 +0200 [thread overview]
Message-ID: <200605152219.37265.jesper.juhl@gmail.com> (raw)
In-Reply-To: <20060514140946.GA23387@mipter.zuzino.mipt.ru>
On Sunday 14 May 2006 16:09, Alexey Dobriyan wrote:
> On Sun, May 14, 2006 at 03:12:50PM +0200, Jesper Juhl wrote:
> > Testing a pointer for NULL after it has already been dereferenced is not
> > very safe.
> > Patch below to rework yam_open() so that `dev' is not dereferenced until
> > after it has been tested for NULL.
>
> > Found by coverity checker as #787
>
> > --- linux-2.6.17-rc4-git2-orig/drivers/net/hamradio/yam.c
> > +++ linux-2.6.17-rc4-git2/drivers/net/hamradio/yam.c
> > @@ -845,15 +845,25 @@ static struct net_device_stats *yam_get_
> >
> > static int yam_open(struct net_device *dev)
> > {
> > - struct yam_port *yp = netdev_priv(dev);
> > + struct yam_port *yp;
> > enum uart u;
> > int i;
> > - int ret=0;
> > + int ret = 0;
>
> Please, don't make unrelated changes.
>
Sorry.
> > - printk(KERN_INFO "Trying %s at iobase 0x%lx irq %u\n", dev->name, dev->base_addr, dev->irq);
> > + if (!dev) {
> > + printk(KERN_ERR "yam_open() called without device\n");
> > + return -ENXIO;
> > + }
>
> How can it be NULL here? The whole array of valid net_devices was
> allocated at module init time.
>
It cannot. You are right, I'm wrong.
I guess removing the check makes sense then ?
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
--- linux-2.6.17-rc4-mm1-orig/drivers/net/hamradio/yam.c 2006-05-13 21:28:27.000000000 +0200
+++ linux-2.6.17-rc4-mm1/drivers/net/hamradio/yam.c 2006-05-15 22:16:32.000000000 +0200
@@ -852,7 +852,7 @@ static int yam_open(struct net_device *d
printk(KERN_INFO "Trying %s at iobase 0x%lx irq %u\n", dev->name, dev->base_addr, dev->irq);
- if (!dev || !yp->bitrate)
+ if (!yp->bitrate)
return -ENXIO;
if (!dev->base_addr || dev->base_addr > 0x1000 - YAM_EXTENT ||
dev->irq < 2 || dev->irq > 15) {
next prev parent reply other threads:[~2006-05-15 20:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-14 13:12 [PATCH] fix potential NULL pointer dereference in yam Jesper Juhl
2006-05-14 14:09 ` Alexey Dobriyan
2006-05-15 20:19 ` Jesper Juhl [this message]
2006-05-16 9:57 ` Ralf Baechle
2006-05-14 17:08 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605152219.37265.jesper.juhl@gmail.com \
--to=jesper.juhl@gmail.com \
--cc=adobriyan@gmail.com \
--cc=frible@teaser.fr \
--cc=jpr@f6fbb.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox