From: Jesper Juhl <jesper.juhl@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Moxa Technologies <support@moxa.com.tw>,
Alan Cox <alan@redhat.com>, Martin Mares <mj@ucw.cz>,
Alexey Dobriyan <adobriyan@gmail.com>,
Jesper Juhl <jesper.juhl@gmail.com>
Subject: [PATCH 2/3] moxa: remove pointless check of 'tty' argument vs NULL
Date: Mon, 15 May 2006 23:57:35 +0200 [thread overview]
Message-ID: <200605152357.36018.jesper.juhl@gmail.com> (raw)
Remove pointless check of 'tty' argument vs NULL from moxa driver.
(applies on top of patch 1/3)
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
drivers/char/mxser.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.17-rc4-mm1/drivers/char/mxser.c.1 2006-05-15 22:33:49.000000000 +0200
+++ linux-2.6.17-rc4-mm1/drivers/char/mxser.c 2006-05-15 22:34:38.000000000 +0200
@@ -1081,7 +1081,7 @@ static int mxser_write(struct tty_struct
struct mxser_struct *info = tty->driver_data;
unsigned long flags;
- if (!tty || !info->xmit_buf)
+ if (!info->xmit_buf)
return (0);
while (1) {
@@ -1117,7 +1117,7 @@ static void mxser_put_char(struct tty_st
struct mxser_struct *info = tty->driver_data;
unsigned long flags;
- if (!tty || !info->xmit_buf)
+ if (!info->xmit_buf)
return;
if (info->xmit_cnt >= SERIAL_XMIT_SIZE - 1)
next reply other threads:[~2006-05-15 21:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-15 21:57 Jesper Juhl [this message]
2006-05-15 21:59 ` [PATCH 2/3] moxa: remove pointless check of 'tty' argument vs NULL Alan Cox
2006-05-15 22:08 ` Jesper Juhl
2006-05-15 22:49 ` Alan Cox
2006-05-15 22:09 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605152357.36018.jesper.juhl@gmail.com \
--to=jesper.juhl@gmail.com \
--cc=adobriyan@gmail.com \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mj@ucw.cz \
--cc=support@moxa.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox