RE: Regression seen for patch "sched:dont decrease idle sleep avg"

Mike Galbraith
2006-05-16T04:06:45Z

On Mon, 2006-05-15 at 12:01 -0700, Chen, Kenneth W wrote:

> [patch] sched: update comments in priority calculation w.r.t. implementation.
>
> Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>
>
> --- ./kernel/sched.c.orig 2006-05-15 12:24:02.000000000 -0700
> +++ ./kernel/sched.c 2006-05-15 12:37:16.000000000 -0700
> @@ -746,10 +746,12 @@ static int recalc_task_prio(task_t *p, u
> if (likely(sleep_time > 0)) {
> /*
> * User tasks that sleep a long time are categorised as
> - * idle. They will only have their sleep_avg increased to a
> - * level that makes them just interactive priority to stay
> - * active yet prevent them suddenly becoming cpu hogs and
> - * starving other processes.
> + * idle. If they sleep longer than INTERACTIVE_SLEEP, it
> + * will have its priority boosted to minimum MAX_BONUS-1.
> + * For short sleep, they will only have their sleep_avg
> + * increased to a level that makes them just interactive
> + * priority to stay active yet prevent them suddenly becoming
> + * cpu hogs and starving other processes.
> */
> if (p->mm && sleep_time > INTERACTIVE_SLEEP(p)) {
> unsigned long ceiling;

This comment still doesn't reflect what the code does. Please just
delete the last four lines, they are incorrect.

-Mike