Re: 2.6.17-rc4-mm1

Stephen Hemminger
2006-05-16T15:18:39Z

Jean Delvare wrote:
> Michal Piotrowski reported:
>
>>> When I try to "modprobe -r i2c_i801" modprobe hangs
>>>
>
> Quoting myself:
>
>> I can reproduce it, with both i2c-i801 and i2c-parport, so it's not
>> related to a specific driver. I'm currently performing a bisection on
>> 2.6.17-rc4-mm1 to try and isolate the culprit. It seems to point to
>> gregkh-driver-*. i2c patches are innocent for sure, including Kumar's
>> ones.
>>
>
> And the winner is...
> gregkh-driver-driver-core-class_device_add-needs-error-checks.patch
>
> Stephen, Greg?
>
>
Look at the error return from class_device_register. I bet
it was working before because the class_device_register wasn't
checking something, now it is and that exposes a bug that has
existed in i2c since sysfs support was added.

I can make up a more verbose version if that helps