Re: 2.6.17-rc4-mm1

Takashi Iwai
2006-05-16T09:04:42Z

At Mon, 15 May 2006 11:11:11 -0700,
Andrew Morton wrote:
>
> Takashi Iwai <tiwai@suse.de> wrote:
> >
> > -unsigned int snd_cards_lock = 0; /* locked for registering/using */
> > +static unsigned int snd_cards_lock = 0; /* locked for registering/using */
>
> May as well remove the `= 0' while you're there. It adds four bytes to the
> module unnecessarily.

Yep. Will remove it.

> > void snd_request_card(int card)
> > {
> > - int locked;
> > -
> > if (! current->fs->root)
> > return;
>
> I wonder what that's there for.

This is almost for backward compatibility only.
We have already module aliases, so it can be cleaned up.

Takashi