From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, Luc Saillard <luc@saillard.org>
Cc: linux-kernel@vger.kernel.org, v4l-dvb-maintainer@linuxtv.org
Subject: [-mm patch] drivers/media/video/pwc/: make code static
Date: Tue, 16 May 2006 14:15:11 +0200 [thread overview]
Message-ID: <20060516121510.GP6931@stusta.de> (raw)
In-Reply-To: <20060515005637.00b54560.akpm@osdl.org>
On Mon, May 15, 2006 at 12:56:37AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.17-rc3-mm1:
>...
> git-dvb.patch
>...
> git trees
>...
This patch makes the following needlessly global code static:
- pwc-ctrl.c: pwc_get_leds()
- pwc_preferred_compression
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/media/video/pwc/pwc-ctrl.c | 2 +-
drivers/media/video/pwc/pwc-if.c | 2 +-
drivers/media/video/pwc/pwc.h | 2 --
3 files changed, 2 insertions(+), 4 deletions(-)
--- linux-2.6.17-rc4-mm1-full/drivers/media/video/pwc/pwc.h.old 2006-05-16 12:54:35.000000000 +0200
+++ linux-2.6.17-rc4-mm1-full/drivers/media/video/pwc/pwc.h 2006-05-16 12:55:17.000000000 +0200
@@ -274,7 +274,6 @@
#if CONFIG_PWC_DEBUG
extern int pwc_trace;
#endif
-extern int pwc_preferred_compression;
extern int pwc_mbufs;
/** functions in pwc-if.c */
@@ -308,7 +307,6 @@
extern int pwc_get_saturation(struct pwc_device *pdev, int *value);
extern int pwc_set_saturation(struct pwc_device *pdev, int value);
extern int pwc_set_leds(struct pwc_device *pdev, int on_value, int off_value);
-extern int pwc_get_leds(struct pwc_device *pdev, int *on_value, int *off_value);
extern int pwc_get_cmos_sensor(struct pwc_device *pdev, int *sensor);
extern int pwc_restore_user(struct pwc_device *pdev);
extern int pwc_save_user(struct pwc_device *pdev);
--- linux-2.6.17-rc4-mm1-full/drivers/media/video/pwc/pwc-ctrl.c.old 2006-05-16 12:54:49.000000000 +0200
+++ linux-2.6.17-rc4-mm1-full/drivers/media/video/pwc/pwc-ctrl.c 2006-05-16 12:54:55.000000000 +0200
@@ -925,7 +925,7 @@
return SendControlMsg(SET_STATUS_CTL, LED_FORMATTER, 2);
}
-int pwc_get_leds(struct pwc_device *pdev, int *on_value, int *off_value)
+static int pwc_get_leds(struct pwc_device *pdev, int *on_value, int *off_value)
{
unsigned char buf[2];
int ret;
--- linux-2.6.17-rc4-mm1-full/drivers/media/video/pwc/pwc-if.c.old 2006-05-16 12:55:26.000000000 +0200
+++ linux-2.6.17-rc4-mm1-full/drivers/media/video/pwc/pwc-if.c 2006-05-16 12:55:36.000000000 +0200
@@ -133,7 +133,7 @@
#endif
static int power_save = 0;
static int led_on = 100, led_off = 0; /* defaults to LED that is on while in use */
- int pwc_preferred_compression = 1; /* 0..3 = uncompressed..high */
+static int pwc_preferred_compression = 1; /* 0..3 = uncompressed..high */
static struct {
int type;
char serial_number[30];
next prev parent reply other threads:[~2006-05-16 12:15 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-15 7:56 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 10:09 ` 2.6.17-rc4-mm1 Eric Dumazet
2006-05-15 11:03 ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 11:42 ` 2.6.17-rc4-mm1 Pekka Enberg
2006-05-15 13:28 ` 2.6.17-rc4-mm1 Eric Dumazet
2006-05-15 13:12 ` 2.6.17-rc4-mm1 Reuben Farrelly
2006-05-15 22:09 ` 2.6.17-rc4-mm1 Neil Brown
2006-05-15 14:08 ` [PATCH] x86 NUMA panic compile error Andy Whitcroft
2006-05-15 17:53 ` Ingo Molnar
2006-05-15 18:01 ` Andi Kleen
2006-05-15 18:14 ` Ingo Molnar
2006-05-15 18:08 ` Andrew Morton
2006-05-15 18:08 ` Andy Whitcroft
2006-05-15 18:24 ` Andrew Morton
2006-05-15 18:24 ` Andi Kleen
2006-05-15 19:45 ` Martin Bligh
2006-05-15 18:13 ` Andi Kleen
2006-05-15 18:31 ` Ingo Molnar
2006-05-15 18:34 ` Andrew Morton
2006-05-15 18:37 ` Andi Kleen
2006-05-15 18:49 ` Ingo Molnar
2006-05-15 19:05 ` Dave Hansen
2006-05-15 19:11 ` Andi Kleen
2006-05-15 19:26 ` Ingo Molnar
2006-05-15 19:38 ` Andi Kleen
2006-05-16 7:06 ` Ingo Molnar
2006-05-16 9:22 ` Andi Kleen
2006-05-15 19:39 ` Andrew Morton
2006-05-15 19:47 ` Andi Kleen
2006-05-15 19:59 ` Andrew Morton
2006-05-15 20:02 ` Andi Kleen
2006-05-15 23:06 ` H. Peter Anvin
2006-05-17 0:39 ` Dave Jones
2006-05-17 1:21 ` H. Peter Anvin
2006-05-15 18:43 ` Ingo Molnar
2006-05-15 18:28 ` Ingo Molnar
2006-05-15 18:52 ` Andrew Morton
2006-05-15 18:56 ` Andi Kleen
2006-05-15 18:59 ` Ingo Molnar
2006-05-15 18:56 ` Ingo Molnar
2006-05-15 19:06 ` Ingo Molnar
2006-05-15 16:40 ` 2.6.17-rc4-mm1 Michal Piotrowski
2006-05-15 17:04 ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 17:30 ` 2.6.17-rc4-mm1 Takashi Iwai
2006-05-15 17:56 ` 2.6.17-rc4-mm1 Takashi Iwai
2006-05-15 18:11 ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-16 9:04 ` 2.6.17-rc4-mm1 Takashi Iwai
2006-05-15 18:50 ` 2.6.17-rc4-mm1 Michal Piotrowski
2006-05-15 16:49 ` 2.6.17-rc4-mm1 Alexey Dobriyan
2006-05-15 17:01 ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 18:01 ` 2.6.17-rc4-mm1 Alexey Dobriyan
2006-05-15 19:29 ` 2.6.17-rc4-mm1 Michael Halcrow
2006-05-15 17:48 ` 2.6.17-rc4-mm1 Michal Piotrowski
2006-05-15 18:00 ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 18:05 ` 2.6.17-rc4-mm1 Jesper Juhl
2006-05-15 18:37 ` 2.6.17-rc4-mm1 Michal Piotrowski
2006-05-15 18:53 ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 19:10 ` 2.6.17-rc4-mm1 Michal Piotrowski
2006-05-15 19:26 ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 20:17 ` 2.6.17-rc4-mm1 Michal Piotrowski
2006-05-16 8:39 ` 2.6.17-rc4-mm1 Jean Delvare
2006-05-16 12:55 ` 2.6.17-rc4-mm1 Jean Delvare
2006-05-16 14:48 ` 2.6.17-rc4-mm1 Jean Delvare
2006-05-16 15:18 ` 2.6.17-rc4-mm1 Stephen Hemminger
2006-05-16 15:23 ` 2.6.17-rc4-mm1 Jean Delvare
2006-05-16 16:08 ` 2.6.17-rc4-mm1 Greg KH
2006-05-16 16:27 ` 2.6.17-rc4-mm1 Stephen Hemminger
2006-05-16 16:49 ` 2.6.17-rc4-mm1 Greg KH
2006-05-15 19:28 ` 2.6.17-rc4-mm1 Ingo Molnar
[not found] ` <6bffcb0e0605151003x5d3518b9o70dae3b3349c4f9f@mail.gmail.com>
2006-05-15 22:24 ` 2.6.17-rc4-mm1 David Woodhouse
2006-05-16 10:25 ` 2.6.17-rc4-mm1: no help text for MTD_NAND_CS553 Adrian Bunk
2006-05-16 12:13 ` David Woodhouse
2006-05-16 11:46 ` [-mm patch] drivers/mtd/devices/docprobe.c: correct #if's Adrian Bunk
2006-05-16 12:14 ` David Woodhouse
2006-05-16 11:48 ` [-mm patch] make dvb/b2c2/flexcop-fe-tuner.c:alps_tdee4_stv0297_tuner_set_params() static Adrian Bunk
2006-05-16 12:15 ` Adrian Bunk [this message]
2006-05-16 12:32 ` [-mm patch] make variables static after klibc merge Adrian Bunk
2006-05-16 12:37 ` [-mm patch] make drivers/mtd/nand/cs553x_nand.c:cs553x_init() static Adrian Bunk
2006-05-16 13:04 ` David Woodhouse
2006-05-16 12:39 ` [-mm patch] fs/nfs/: make code static Adrian Bunk
2006-05-16 13:24 ` [-mm patch] arch/i386/oprofile/: make functions static Adrian Bunk
2006-05-16 18:16 ` Andi Kleen
2006-05-16 19:07 ` Andi Kleen
2006-05-16 15:26 ` [-mm patch] fs/ocfs2/dlm/: cleanups Adrian Bunk
2006-05-17 1:36 ` Mark Fasheh
2006-05-16 15:30 ` [-mm patch] drivers/net/s2io.c: make bus_speed[] static Adrian Bunk
2006-05-16 15:36 ` Andreas Mohr
2006-05-16 16:42 ` Adrian Bunk
2006-05-24 5:28 ` Jeff Garzik
2006-05-16 16:12 ` 2.6.17-rc4-mm1: please drop add-raw-driver-kconfig-entry-for-s390.patch Adrian Bunk
2006-05-16 16:37 ` Olaf Hering
2006-05-16 17:44 ` [2.6 patch] the overdue removal of the obsolete raw driver Adrian Bunk
2006-05-16 17:50 ` Olaf Hering
2006-05-17 13:12 ` 2.6.17-rc4-mm1: please drop add-raw-driver-kconfig-entry-for-s390.patch Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2006-06-22 10:03 [-mm patch] drivers/media/video/pwc/: make code static Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060516121510.GP6931@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luc@saillard.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox