From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>,
mark.fasheh@oracle.com, kurt.hackel@oracle.com
Cc: linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: [-mm patch] fs/ocfs2/dlm/: cleanups
Date: Tue, 16 May 2006 17:26:41 +0200 [thread overview]
Message-ID: <20060516152641.GA5677@stusta.de> (raw)
In-Reply-To: <20060515005637.00b54560.akpm@osdl.org>
On Mon, May 15, 2006 at 12:56:37AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.17-rc3-mm1:
>...
> git-ocfs2.patch
>...
> git trees
>...
This patch #if 0's the no longer used dlm_dump_lock_resources().
Since this makes dlmdebug.h empty, this patch also removes this header.
Additionally, the needlessly global dlm_is_node_recovered() is made
static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
fs/ocfs2/dlm/dlmdebug.c | 4 ++--
fs/ocfs2/dlm/dlmdebug.h | 30 ------------------------------
fs/ocfs2/dlm/dlmdomain.c | 1 -
fs/ocfs2/dlm/dlmmaster.c | 1 -
fs/ocfs2/dlm/dlmrecovery.c | 2 +-
5 files changed, 3 insertions(+), 35 deletions(-)
--- linux-2.6.17-rc4-mm1-full/fs/ocfs2/dlm/dlmdebug.h 2006-03-20 06:53:29.000000000 +0100
+++ /dev/null 2006-04-23 00:42:46.000000000 +0200
@@ -1,30 +0,0 @@
-/* -*- mode: c; c-basic-offset: 8; -*-
- * vim: noexpandtab sw=8 ts=8 sts=0:
- *
- * dlmdebug.h
- *
- * Copyright (C) 2004 Oracle. All rights reserved.
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public
- * License along with this program; if not, write to the
- * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
- * Boston, MA 021110-1307, USA.
- *
- */
-
-#ifndef DLMDEBUG_H
-#define DLMDEBUG_H
-
-void dlm_dump_lock_resources(struct dlm_ctxt *dlm);
-
-#endif
--- linux-2.6.17-rc4-mm1-full/fs/ocfs2/dlm/dlmdebug.c.old 2006-05-16 13:16:46.000000000 +0200
+++ linux-2.6.17-rc4-mm1-full/fs/ocfs2/dlm/dlmdebug.c 2006-05-16 13:17:16.000000000 +0200
@@ -37,10 +37,8 @@
#include "dlmapi.h"
#include "dlmcommon.h"
-#include "dlmdebug.h"
#include "dlmdomain.h"
-#include "dlmdebug.h"
#define MLOG_MASK_PREFIX ML_DLM
#include "cluster/masklog.h"
@@ -120,6 +118,7 @@
}
EXPORT_SYMBOL_GPL(dlm_print_one_lock);
+#if 0
void dlm_dump_lock_resources(struct dlm_ctxt *dlm)
{
struct dlm_lock_resource *res;
@@ -142,6 +141,7 @@
}
spin_unlock(&dlm->spinlock);
}
+#endif /* 0 */
static const char *dlm_errnames[] = {
[DLM_NORMAL] = "DLM_NORMAL",
--- linux-2.6.17-rc4-mm1-full/fs/ocfs2/dlm/dlmdomain.c.old 2006-05-16 13:17:25.000000000 +0200
+++ linux-2.6.17-rc4-mm1-full/fs/ocfs2/dlm/dlmdomain.c 2006-05-16 13:17:28.000000000 +0200
@@ -41,7 +41,6 @@
#include "dlmapi.h"
#include "dlmcommon.h"
-#include "dlmdebug.h"
#include "dlmdomain.h"
#include "dlmver.h"
--- linux-2.6.17-rc4-mm1-full/fs/ocfs2/dlm/dlmmaster.c.old 2006-05-16 13:17:36.000000000 +0200
+++ linux-2.6.17-rc4-mm1-full/fs/ocfs2/dlm/dlmmaster.c 2006-05-16 13:17:39.000000000 +0200
@@ -47,7 +47,6 @@
#include "dlmapi.h"
#include "dlmcommon.h"
-#include "dlmdebug.h"
#include "dlmdomain.h"
#define MLOG_MASK_PREFIX (ML_DLM|ML_DLM_MASTER)
--- linux-2.6.17-rc4-mm1-full/fs/ocfs2/dlm/dlmrecovery.c.old 2006-05-16 13:18:14.000000000 +0200
+++ linux-2.6.17-rc4-mm1-full/fs/ocfs2/dlm/dlmrecovery.c 2006-05-16 13:18:22.000000000 +0200
@@ -357,7 +357,7 @@
/* returns true if node is no longer in the domain
* could be dead or just not joined */
-int dlm_is_node_recovered(struct dlm_ctxt *dlm, u8 node)
+static int dlm_is_node_recovered(struct dlm_ctxt *dlm, u8 node)
{
int recovered;
spin_lock(&dlm->spinlock);
next prev parent reply other threads:[~2006-05-16 15:26 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-15 7:56 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 10:09 ` 2.6.17-rc4-mm1 Eric Dumazet
2006-05-15 11:03 ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 11:42 ` 2.6.17-rc4-mm1 Pekka Enberg
2006-05-15 13:28 ` 2.6.17-rc4-mm1 Eric Dumazet
2006-05-15 13:12 ` 2.6.17-rc4-mm1 Reuben Farrelly
2006-05-15 22:09 ` 2.6.17-rc4-mm1 Neil Brown
2006-05-15 14:08 ` [PATCH] x86 NUMA panic compile error Andy Whitcroft
2006-05-15 17:53 ` Ingo Molnar
2006-05-15 18:01 ` Andi Kleen
2006-05-15 18:14 ` Ingo Molnar
2006-05-15 18:08 ` Andrew Morton
2006-05-15 18:08 ` Andy Whitcroft
2006-05-15 18:24 ` Andrew Morton
2006-05-15 18:24 ` Andi Kleen
2006-05-15 19:45 ` Martin Bligh
2006-05-15 18:13 ` Andi Kleen
2006-05-15 18:31 ` Ingo Molnar
2006-05-15 18:34 ` Andrew Morton
2006-05-15 18:37 ` Andi Kleen
2006-05-15 18:49 ` Ingo Molnar
2006-05-15 19:05 ` Dave Hansen
2006-05-15 19:11 ` Andi Kleen
2006-05-15 19:26 ` Ingo Molnar
2006-05-15 19:38 ` Andi Kleen
2006-05-16 7:06 ` Ingo Molnar
2006-05-16 9:22 ` Andi Kleen
2006-05-15 19:39 ` Andrew Morton
2006-05-15 19:47 ` Andi Kleen
2006-05-15 19:59 ` Andrew Morton
2006-05-15 20:02 ` Andi Kleen
2006-05-15 23:06 ` H. Peter Anvin
2006-05-17 0:39 ` Dave Jones
2006-05-17 1:21 ` H. Peter Anvin
2006-05-15 18:43 ` Ingo Molnar
2006-05-15 18:28 ` Ingo Molnar
2006-05-15 18:52 ` Andrew Morton
2006-05-15 18:56 ` Andi Kleen
2006-05-15 18:59 ` Ingo Molnar
2006-05-15 18:56 ` Ingo Molnar
2006-05-15 19:06 ` Ingo Molnar
2006-05-15 16:40 ` 2.6.17-rc4-mm1 Michal Piotrowski
2006-05-15 17:04 ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 17:30 ` 2.6.17-rc4-mm1 Takashi Iwai
2006-05-15 17:56 ` 2.6.17-rc4-mm1 Takashi Iwai
2006-05-15 18:11 ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-16 9:04 ` 2.6.17-rc4-mm1 Takashi Iwai
2006-05-15 18:50 ` 2.6.17-rc4-mm1 Michal Piotrowski
2006-05-15 16:49 ` 2.6.17-rc4-mm1 Alexey Dobriyan
2006-05-15 17:01 ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 18:01 ` 2.6.17-rc4-mm1 Alexey Dobriyan
2006-05-15 19:29 ` 2.6.17-rc4-mm1 Michael Halcrow
2006-05-15 17:48 ` 2.6.17-rc4-mm1 Michal Piotrowski
2006-05-15 18:00 ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 18:05 ` 2.6.17-rc4-mm1 Jesper Juhl
2006-05-15 18:37 ` 2.6.17-rc4-mm1 Michal Piotrowski
2006-05-15 18:53 ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 19:10 ` 2.6.17-rc4-mm1 Michal Piotrowski
2006-05-15 19:26 ` 2.6.17-rc4-mm1 Andrew Morton
2006-05-15 20:17 ` 2.6.17-rc4-mm1 Michal Piotrowski
2006-05-16 8:39 ` 2.6.17-rc4-mm1 Jean Delvare
2006-05-16 12:55 ` 2.6.17-rc4-mm1 Jean Delvare
2006-05-16 14:48 ` 2.6.17-rc4-mm1 Jean Delvare
2006-05-16 15:18 ` 2.6.17-rc4-mm1 Stephen Hemminger
2006-05-16 15:23 ` 2.6.17-rc4-mm1 Jean Delvare
2006-05-16 16:08 ` 2.6.17-rc4-mm1 Greg KH
2006-05-16 16:27 ` 2.6.17-rc4-mm1 Stephen Hemminger
2006-05-16 16:49 ` 2.6.17-rc4-mm1 Greg KH
2006-05-15 19:28 ` 2.6.17-rc4-mm1 Ingo Molnar
[not found] ` <6bffcb0e0605151003x5d3518b9o70dae3b3349c4f9f@mail.gmail.com>
2006-05-15 22:24 ` 2.6.17-rc4-mm1 David Woodhouse
2006-05-16 10:25 ` 2.6.17-rc4-mm1: no help text for MTD_NAND_CS553 Adrian Bunk
2006-05-16 12:13 ` David Woodhouse
2006-05-16 11:46 ` [-mm patch] drivers/mtd/devices/docprobe.c: correct #if's Adrian Bunk
2006-05-16 12:14 ` David Woodhouse
2006-05-16 11:48 ` [-mm patch] make dvb/b2c2/flexcop-fe-tuner.c:alps_tdee4_stv0297_tuner_set_params() static Adrian Bunk
2006-05-16 12:15 ` [-mm patch] drivers/media/video/pwc/: make code static Adrian Bunk
2006-05-16 12:32 ` [-mm patch] make variables static after klibc merge Adrian Bunk
2006-05-16 12:37 ` [-mm patch] make drivers/mtd/nand/cs553x_nand.c:cs553x_init() static Adrian Bunk
2006-05-16 13:04 ` David Woodhouse
2006-05-16 12:39 ` [-mm patch] fs/nfs/: make code static Adrian Bunk
2006-05-16 13:24 ` [-mm patch] arch/i386/oprofile/: make functions static Adrian Bunk
2006-05-16 18:16 ` Andi Kleen
2006-05-16 19:07 ` Andi Kleen
2006-05-16 15:26 ` Adrian Bunk [this message]
2006-05-17 1:36 ` [-mm patch] fs/ocfs2/dlm/: cleanups Mark Fasheh
2006-05-16 15:30 ` [-mm patch] drivers/net/s2io.c: make bus_speed[] static Adrian Bunk
2006-05-16 15:36 ` Andreas Mohr
2006-05-16 16:42 ` Adrian Bunk
2006-05-24 5:28 ` Jeff Garzik
2006-05-16 16:12 ` 2.6.17-rc4-mm1: please drop add-raw-driver-kconfig-entry-for-s390.patch Adrian Bunk
2006-05-16 16:37 ` Olaf Hering
2006-05-16 17:44 ` [2.6 patch] the overdue removal of the obsolete raw driver Adrian Bunk
2006-05-16 17:50 ` Olaf Hering
2006-05-17 13:12 ` 2.6.17-rc4-mm1: please drop add-raw-driver-kconfig-entry-for-s390.patch Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060516152641.GA5677@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=kurt.hackel@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.fasheh@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox