From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [RFC: 2.6 patch] fs/jbd/journal.c: possible cleanups
Date: Tue, 16 May 2006 19:44:13 +0200 [thread overview]
Message-ID: <20060516174413.GI10077@stusta.de> (raw)
This patch contains the following possible cleanups:
- make the following needlessly global function static:
- journal_check_used_features()
- remove the following unused EXPORT_SYMBOL's:
- journal_set_features
- journal_update_superblock
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 1 May 2006
- 23 Apr 2006
fs/jbd/journal.c | 9 ++++-----
include/linux/jbd.h | 2 --
2 files changed, 4 insertions(+), 7 deletions(-)
--- linux-2.6.17-rc1-mm3-full/include/linux/jbd.h.old 2006-04-23 13:29:20.000000000 +0200
+++ linux-2.6.17-rc1-mm3-full/include/linux/jbd.h 2006-04-23 13:29:35.000000000 +0200
@@ -908,8 +908,6 @@
int start, int len, int bsize);
extern journal_t * journal_init_inode (struct inode *);
extern int journal_update_format (journal_t *);
-extern int journal_check_used_features
- (journal_t *, unsigned long, unsigned long, unsigned long);
extern int journal_check_available_features
(journal_t *, unsigned long, unsigned long, unsigned long);
extern int journal_set_features
--- linux-2.6.17-rc1-mm3-full/fs/jbd/journal.c.old 2006-04-23 13:29:42.000000000 +0200
+++ linux-2.6.17-rc1-mm3-full/fs/jbd/journal.c 2006-04-23 13:30:37.000000000 +0200
@@ -62,13 +62,10 @@
EXPORT_SYMBOL(journal_init_dev);
EXPORT_SYMBOL(journal_init_inode);
EXPORT_SYMBOL(journal_update_format);
-EXPORT_SYMBOL(journal_check_used_features);
EXPORT_SYMBOL(journal_check_available_features);
-EXPORT_SYMBOL(journal_set_features);
EXPORT_SYMBOL(journal_create);
EXPORT_SYMBOL(journal_load);
EXPORT_SYMBOL(journal_destroy);
-EXPORT_SYMBOL(journal_update_superblock);
EXPORT_SYMBOL(journal_abort);
EXPORT_SYMBOL(journal_errno);
EXPORT_SYMBOL(journal_ack_err);
@@ -1169,8 +1166,10 @@
* features. Return true (non-zero) if it does.
**/
-int journal_check_used_features (journal_t *journal, unsigned long compat,
- unsigned long ro, unsigned long incompat)
+static int journal_check_used_features(journal_t *journal,
+ unsigned long compat,
+ unsigned long ro,
+ unsigned long incompat)
{
journal_superblock_t *sb;
next reply other threads:[~2006-05-16 17:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-16 17:44 Adrian Bunk [this message]
2006-05-16 19:27 ` [RFC: 2.6 patch] fs/jbd/journal.c: possible cleanups Andrew Morton
2006-05-16 19:39 ` Adrian Bunk
2006-05-16 19:50 ` Andrew Morton
2006-05-18 11:52 ` Stephen C. Tweedie
2006-05-16 21:14 ` Theodore Tso
2006-05-16 21:33 ` Adrian Bunk
2006-05-16 22:26 ` [PATCH] Update ext2/ext3/jbd MAINTAINERS entries Theodore Tso
2006-05-18 11:48 ` Stephen C. Tweedie
2006-05-17 1:33 ` [RFC: 2.6 patch] fs/jbd/journal.c: possible cleanups Arjan van de Ven
2006-05-17 1:40 ` Andrew Morton
2006-05-17 1:51 ` Arjan van de Ven
2006-05-17 1:58 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2006-05-01 7:11 Adrian Bunk
2006-04-23 11:49 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060516174413.GI10077@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox