* [RFC: 2.6 patch] fs/bio.c: possible cleanups
@ 2006-04-23 11:33 Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2006-04-23 11:33 UTC (permalink / raw)
To: axboe; +Cc: linux-kernel
This patch contains the following possible cleanups:
- make the follwing needlessly global function static:
- __bio_clone()
- don't mark the following _global_ functions as inline:
- bio_phys_segments()
- bio_hw_segments()
- remove the following unused EXPORT_SYMBOL's:
- bio_phys_segments
- bio_hw_segments
- bio_map_kern
- bio_copy_user
- bio_uncopy_user
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
fs/bio.c | 12 +++---------
include/linux/bio.h | 1 -
2 files changed, 3 insertions(+), 10 deletions(-)
--- linux-2.6.17-rc1-mm3-full/include/linux/bio.h.old 2006-04-23 12:02:44.000000000 +0200
+++ linux-2.6.17-rc1-mm3-full/include/linux/bio.h 2006-04-23 12:02:50.000000000 +0200
@@ -286,7 +286,6 @@
extern int bio_phys_segments(struct request_queue *, struct bio *);
extern int bio_hw_segments(struct request_queue *, struct bio *);
-extern void __bio_clone(struct bio *, struct bio *);
extern struct bio *bio_clone(struct bio *, gfp_t);
extern void bio_init(struct bio *);
--- linux-2.6.17-rc1-mm3-full/fs/bio.c.old 2006-04-23 12:02:57.000000000 +0200
+++ linux-2.6.17-rc1-mm3-full/fs/bio.c 2006-04-23 12:06:04.000000000 +0200
@@ -229,7 +229,7 @@
}
}
-inline int bio_phys_segments(request_queue_t *q, struct bio *bio)
+int bio_phys_segments(request_queue_t *q, struct bio *bio)
{
if (unlikely(!bio_flagged(bio, BIO_SEG_VALID)))
blk_recount_segments(q, bio);
@@ -237,7 +237,7 @@
return bio->bi_phys_segments;
}
-inline int bio_hw_segments(request_queue_t *q, struct bio *bio)
+int bio_hw_segments(request_queue_t *q, struct bio *bio)
{
if (unlikely(!bio_flagged(bio, BIO_SEG_VALID)))
blk_recount_segments(q, bio);
@@ -254,7 +254,7 @@
* the actual data it points to. Reference count of returned
* bio will be one.
*/
-void __bio_clone(struct bio *bio, struct bio *bio_src)
+static void __bio_clone(struct bio *bio, struct bio *bio_src)
{
request_queue_t *q = bdev_get_queue(bio_src->bi_bdev);
@@ -1243,21 +1243,15 @@
EXPORT_SYMBOL(bio_free);
EXPORT_SYMBOL(bio_endio);
EXPORT_SYMBOL(bio_init);
-EXPORT_SYMBOL(__bio_clone);
EXPORT_SYMBOL(bio_clone);
-EXPORT_SYMBOL(bio_phys_segments);
-EXPORT_SYMBOL(bio_hw_segments);
EXPORT_SYMBOL(bio_add_page);
EXPORT_SYMBOL(bio_add_pc_page);
EXPORT_SYMBOL(bio_get_nr_vecs);
EXPORT_SYMBOL(bio_map_user);
EXPORT_SYMBOL(bio_unmap_user);
-EXPORT_SYMBOL(bio_map_kern);
EXPORT_SYMBOL(bio_pair_release);
EXPORT_SYMBOL(bio_split);
EXPORT_SYMBOL(bio_split_pool);
-EXPORT_SYMBOL(bio_copy_user);
-EXPORT_SYMBOL(bio_uncopy_user);
EXPORT_SYMBOL(bioset_create);
EXPORT_SYMBOL(bioset_free);
EXPORT_SYMBOL(bio_alloc_bioset);
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RFC: 2.6 patch] fs/bio.c: possible cleanups
@ 2006-05-16 18:48 Adrian Bunk
2006-05-17 7:01 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2006-05-16 18:48 UTC (permalink / raw)
To: Andrew Morton; +Cc: axboe, linux-kernel
This patch contains the following possible cleanups:
- make the follwing needlessly global function static:
- __bio_clone()
- don't mark the following _global_ functions as inline:
- bio_phys_segments()
- bio_hw_segments()
- remove the following unused EXPORT_SYMBOL's:
- bio_phys_segments
- bio_hw_segments
- bio_map_kern
- bio_copy_user
- bio_uncopy_user
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 23 Apr 2006
fs/bio.c | 12 +++---------
include/linux/bio.h | 1 -
2 files changed, 3 insertions(+), 10 deletions(-)
--- linux-2.6.17-rc1-mm3-full/include/linux/bio.h.old 2006-04-23 12:02:44.000000000 +0200
+++ linux-2.6.17-rc1-mm3-full/include/linux/bio.h 2006-04-23 12:02:50.000000000 +0200
@@ -286,7 +286,6 @@
extern int bio_phys_segments(struct request_queue *, struct bio *);
extern int bio_hw_segments(struct request_queue *, struct bio *);
-extern void __bio_clone(struct bio *, struct bio *);
extern struct bio *bio_clone(struct bio *, gfp_t);
extern void bio_init(struct bio *);
--- linux-2.6.17-rc1-mm3-full/fs/bio.c.old 2006-04-23 12:02:57.000000000 +0200
+++ linux-2.6.17-rc1-mm3-full/fs/bio.c 2006-04-23 12:06:04.000000000 +0200
@@ -229,7 +229,7 @@
}
}
-inline int bio_phys_segments(request_queue_t *q, struct bio *bio)
+int bio_phys_segments(request_queue_t *q, struct bio *bio)
{
if (unlikely(!bio_flagged(bio, BIO_SEG_VALID)))
blk_recount_segments(q, bio);
@@ -237,7 +237,7 @@
return bio->bi_phys_segments;
}
-inline int bio_hw_segments(request_queue_t *q, struct bio *bio)
+int bio_hw_segments(request_queue_t *q, struct bio *bio)
{
if (unlikely(!bio_flagged(bio, BIO_SEG_VALID)))
blk_recount_segments(q, bio);
@@ -254,7 +254,7 @@
* the actual data it points to. Reference count of returned
* bio will be one.
*/
-void __bio_clone(struct bio *bio, struct bio *bio_src)
+static void __bio_clone(struct bio *bio, struct bio *bio_src)
{
request_queue_t *q = bdev_get_queue(bio_src->bi_bdev);
@@ -1243,21 +1243,15 @@
EXPORT_SYMBOL(bio_free);
EXPORT_SYMBOL(bio_endio);
EXPORT_SYMBOL(bio_init);
-EXPORT_SYMBOL(__bio_clone);
EXPORT_SYMBOL(bio_clone);
-EXPORT_SYMBOL(bio_phys_segments);
-EXPORT_SYMBOL(bio_hw_segments);
EXPORT_SYMBOL(bio_add_page);
EXPORT_SYMBOL(bio_add_pc_page);
EXPORT_SYMBOL(bio_get_nr_vecs);
EXPORT_SYMBOL(bio_map_user);
EXPORT_SYMBOL(bio_unmap_user);
-EXPORT_SYMBOL(bio_map_kern);
EXPORT_SYMBOL(bio_pair_release);
EXPORT_SYMBOL(bio_split);
EXPORT_SYMBOL(bio_split_pool);
-EXPORT_SYMBOL(bio_copy_user);
-EXPORT_SYMBOL(bio_uncopy_user);
EXPORT_SYMBOL(bioset_create);
EXPORT_SYMBOL(bioset_free);
EXPORT_SYMBOL(bio_alloc_bioset);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC: 2.6 patch] fs/bio.c: possible cleanups
2006-05-16 18:48 [RFC: 2.6 patch] fs/bio.c: possible cleanups Adrian Bunk
@ 2006-05-17 7:01 ` Jens Axboe
0 siblings, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2006-05-17 7:01 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel
On Tue, May 16 2006, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - make the follwing needlessly global function static:
> - __bio_clone()
NAK, it's part of the API (and I just had to use it the other day with
fcache).
> - don't mark the following _global_ functions as inline:
> - bio_phys_segments()
> - bio_hw_segments()
Ack.
> - remove the following unused EXPORT_SYMBOL's:
> - bio_phys_segments
> - bio_hw_segments
> - bio_map_kern
> - bio_copy_user
> - bio_uncopy_user
NAK, also part of the API. Leave them.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-05-17 7:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-16 18:48 [RFC: 2.6 patch] fs/bio.c: possible cleanups Adrian Bunk
2006-05-17 7:01 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2006-04-23 11:33 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox