public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Eduard Warkentin <eduard.warkentin@gmx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] added support for ASIX 88178 chipset USB Gigabit Ethernet adaptor
Date: Wed, 17 May 2006 16:59:02 -0700	[thread overview]
Message-ID: <20060517235902.GA8060@kroah.com> (raw)
In-Reply-To: <e4gbbs$d37$1@sea.gmane.org>

On Thu, May 18, 2006 at 01:24:45AM +0200, Eduard Warkentin wrote:
> FROM: Eduard Warkentin <eduard.warkentin@gmx.de>
> 
> Added support for detetcion an dworking with a ASIX 88178 based USB-Gigabit
> adaptor. With the patch, it is detected and handled correctly by the asix
> module.
> 
> ---<snip>---
> --- ./drivers/usb/net/asix.c.orig 2006-03-20 06:53:29.000000000 +0100
> +++ ./drivers/usb/net/asix.c  2006-05-18 01:18:52.000000000 +0200
> @@ -913,6 +913,10 @@ static const struct usb_device_id  produc
>          USB_DEVICE (0x0b95, 0x7720),
>          .driver_info = (unsigned long) &ax88772_info,
>  }, {
> +  // ASIX AX88178 10/100/1000
> +  USB_DEVICE (0x0b95, 0x1780),
> +  .driver_info = (unsigned long) &ax88772_info,
> +}, {

Hm, your tabs and spaces are messed up :(

And you didn't CC: the driver maintainer :(

>   // Linksys USB200M Rev 2
>   USB_DEVICE (0x13b1, 0x0018),
>   .driver_info = (unsigned long) &ax88772_info,
> ---<snap>---
> 
> Signed-off-by: Eduard Warkentin <eduard.warkentin@gmx.de>

And you put this at the bottom (it goes up in the changelog description)
:(

Care to try again?

thanks,

greg k-h

  reply	other threads:[~2006-05-18  0:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-17 23:24 [PATCH] added support for ASIX 88178 chipset USB Gigabit Ethernet adaptor Eduard Warkentin
2006-05-17 23:59 ` Greg KH [this message]
2006-05-18 21:52   ` Eduard Warkentin
2006-05-18 22:14     ` Greg KH
2006-05-18 22:34     ` Eduard Warkentin
2006-05-18 22:41       ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2006-05-19 21:32 eduard.warkentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060517235902.GA8060@kroah.com \
    --to=greg@kroah.com \
    --cc=eduard.warkentin@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox