public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Dave Jones <davej@redhat.com>, Ulrich Drepper <drepper@gmail.com>,
	Chris Wedgwood <cw@f00f.org>, dragoran <dragoran@feuerpokemon.de>,
	linux-kernel@vger.kernel.org, ak@suse.de
Subject: Re: IA32 syscall 311 not implemented on x86_64
Date: Sun, 21 May 2006 21:38:18 +0200	[thread overview]
Message-ID: <20060521193818.GE3339@stusta.de> (raw)
In-Reply-To: <20060521185610.GC8250@redhat.com>

On Sun, May 21, 2006 at 02:56:10PM -0400, Dave Jones wrote:
> 
> Actually it is kinda throttled, but only on process name.
> This patch just removes that stuff completely.
> (Also removes a bunch of trailing whitespace)
> 
> Signed-off-by: Dave Jones <davej@redhat.com>
> 
> --- linux-2.6.16.noarch/arch/x86_64/ia32/sys_ia32.c~	2006-05-21 14:50:57.000000000 -0400
> +++ linux-2.6.16.noarch/arch/x86_64/ia32/sys_ia32.c	2006-05-21 14:51:48.000000000 -0400
> @@ -522,17 +522,9 @@ sys32_waitpid(compat_pid_t pid, unsigned
>  }
>  
>  int sys32_ni_syscall(int call)
> -{ 
> -	struct task_struct *me = current;
> -	static char lastcomm[sizeof(me->comm)];
> -
> -	if (strncmp(lastcomm, me->comm, sizeof(lastcomm))) {
> -		printk(KERN_INFO "IA32 syscall %d from %s not implemented\n",
> -		       call, me->comm);
> -		strncpy(lastcomm, me->comm, sizeof(lastcomm));
> -	} 
> -	return -ENOSYS;	       
> -} 
> +{
> +	return -ENOSYS;
> +}
>...

Why can't we remove sys32_ni_syscall() and call sys_ni_syscall() 
instead if all we want to do is to return -ENOSYS?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2006-05-21 19:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-21  8:35 IA32 syscall 311 not implemented on x86_64 dragoran
2006-05-21  8:50 ` Chris Wedgwood
2006-05-21  9:06   ` dragoran
2006-05-21  9:11     ` Chris Wedgwood
2006-05-21  9:26       ` dragoran
2006-05-21  9:54       ` dragoran
2006-05-21 16:03   ` Dave Jones
2006-05-21 18:35     ` Ulrich Drepper
2006-05-21 18:50       ` Dave Jones
2006-05-21 18:56         ` Dave Jones
2006-05-21 19:38           ` Adrian Bunk [this message]
2006-05-21 19:47             ` Dave Jones
2006-05-22  0:17               ` [2.6 patch] x86_64: don't printk for unimplemented 32bit syscalls Adrian Bunk
2006-05-21 22:19           ` IA32 syscall 311 not implemented on x86_64 Andi Kleen
2006-05-21 22:28             ` Dave Jones
2006-05-21 22:37               ` Andi Kleen
2006-05-21 23:48                 ` Dave Jones
2006-05-21 23:51                   ` Chris Wedgwood
2006-05-22  5:59                   ` dragoran
2006-05-22 12:41                     ` Dave Jones
2006-05-23 14:30                 ` Denis Vlasenko
2006-05-21 23:09             ` Andrew Morton
2006-05-21 19:35       ` Chris Wedgwood
2006-05-21 19:38         ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060521193818.GE3339@stusta.de \
    --to=bunk@stusta.de \
    --cc=ak@suse.de \
    --cc=cw@f00f.org \
    --cc=davej@redhat.com \
    --cc=dragoran@feuerpokemon.de \
    --cc=drepper@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox