[PATCH] implicit declaration of function `page_cache_release'

[PATCH] implicit declaration of function `page_cache_release'

[Olaf Hering]

In file included from include2/asm/tlb.h:31,
                 from linux-2.6.13-rc2-olh/arch/ppc64/kernel/pSeries_lpar.c:37:
linux-2.6.13-rc2-olh/include/asm-generic/tlb.h: In function `tlb_flush_mmu':
linux-2.6.13-rc2-olh/include/asm-generic/tlb.h:77: warning: implicit declaration of function `release_pages'
linux-2.6.13-rc2-olh/include/asm-generic/tlb.h: In function `tlb_remove_page':
linux-2.6.13-rc2-olh/include/asm-generic/tlb.h:117: warning: implicit declaration of function `page_cache_release'

Signed-off-by: Olaf Hering <olh@suse.de>

 include/linux/pagemap.h |    2 +-
 include/linux/swap.h    |    1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

Index: linux-2.6.13-rc2-olh/include/linux/pagemap.h
===================================================================
--- linux-2.6.13-rc2-olh.orig/include/linux/pagemap.h
+++ linux-2.6.13-rc2-olh/include/linux/pagemap.h
@@ -48,7 +48,7 @@ static inline void mapping_set_gfp_mask(
 
 #define page_cache_get(page)		get_page(page)
 #define page_cache_release(page)	put_page(page)
-void release_pages(struct page **pages, int nr, int cold);
+extern void release_pages(struct page **pages, int nr, int cold);
 
 static inline struct page *page_cache_alloc(struct address_space *x)
 {
Index: linux-2.6.13-rc2-olh/include/linux/swap.h
===================================================================
--- linux-2.6.13-rc2-olh.orig/include/linux/swap.h
+++ linux-2.6.13-rc2-olh/include/linux/swap.h
@@ -7,6 +7,7 @@
 #include <linux/mmzone.h>
 #include <linux/list.h>
 #include <linux/sched.h>
+#include <linux/pagemap.h>
 #include <asm/atomic.h>
 #include <asm/page.h>
 

Re: [PATCH] implicit declaration of function `page_cache_release'

[Andrew Morton]

Olaf Hering <olh@suse.de> wrote:
>
> 
> In file included from include2/asm/tlb.h:31,
>                  from linux-2.6.13-rc2-olh/arch/ppc64/kernel/pSeries_lpar.c:37:
> linux-2.6.13-rc2-olh/include/asm-generic/tlb.h: In function `tlb_flush_mmu':
> linux-2.6.13-rc2-olh/include/asm-generic/tlb.h:77: warning: implicit declaration of function `release_pages'
> linux-2.6.13-rc2-olh/include/asm-generic/tlb.h: In function `tlb_remove_page':
> linux-2.6.13-rc2-olh/include/asm-generic/tlb.h:117: warning: implicit declaration of function `page_cache_release'
> 
> Signed-off-by: Olaf Hering <olh@suse.de>
> 
>  include/linux/pagemap.h |    2 +-
>  include/linux/swap.h    |    1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> Index: linux-2.6.13-rc2-olh/include/linux/pagemap.h
> ===================================================================
> --- linux-2.6.13-rc2-olh.orig/include/linux/pagemap.h
> +++ linux-2.6.13-rc2-olh/include/linux/pagemap.h
> @@ -48,7 +48,7 @@ static inline void mapping_set_gfp_mask(
>  
>  #define page_cache_get(page)		get_page(page)
>  #define page_cache_release(page)	put_page(page)
> -void release_pages(struct page **pages, int nr, int cold);
> +extern void release_pages(struct page **pages, int nr, int cold);

Why this change?  I think that was just me saving disk space.

>  static inline struct page *page_cache_alloc(struct address_space *x)
>  {
> Index: linux-2.6.13-rc2-olh/include/linux/swap.h
> ===================================================================
> --- linux-2.6.13-rc2-olh.orig/include/linux/swap.h
> +++ linux-2.6.13-rc2-olh/include/linux/swap.h
> @@ -7,6 +7,7 @@
>  #include <linux/mmzone.h>
>  #include <linux/list.h>
>  #include <linux/sched.h>
> +#include <linux/pagemap.h>
>  #include <asm/atomic.h>
>  #include <asm/page.h>
>

Yup.

Re: [PATCH] implicit declaration of function `page_cache_release'

[Olaf Hering]

 On Fri, Jul 08, Andrew Morton wrote:

> > +++ linux-2.6.13-rc2-olh/include/linux/pagemap.h
> > @@ -48,7 +48,7 @@ static inline void mapping_set_gfp_mask(
> >  
> >  #define page_cache_get(page)		get_page(page)
> >  #define page_cache_release(page)	put_page(page)
> > -void release_pages(struct page **pages, int nr, int cold);
> > +extern void release_pages(struct page **pages, int nr, int cold);
> 
> Why this change?  I think that was just me saving disk space.

Its only used in mm/swap.c and in linux/swap.h.
However, swap.h is used in many places. If no extern works as well, just
drop that part.

Re: [PATCH] implicit declaration of function `page_cache_release'

[Benoit Boissinot]

On 7/8/05, Olaf Hering <olh@suse.de> wrote:
> 
> In file included from include2/asm/tlb.h:31,
>                  from linux-2.6.13-rc2-olh/arch/ppc64/kernel/pSeries_lpar.c:37:
> linux-2.6.13-rc2-olh/include/asm-generic/tlb.h: In function `tlb_flush_mmu':
> linux-2.6.13-rc2-olh/include/asm-generic/tlb.h:77: warning: implicit declaration of function `release_pages'
> linux-2.6.13-rc2-olh/include/asm-generic/tlb.h: In function `tlb_remove_page':
> linux-2.6.13-rc2-olh/include/asm-generic/tlb.h:117: warning: implicit declaration of function `page_cache_release'
> 
This went in 2.6.13-rc3 (commit
542d1c88bd7f73e2e59d41b12e4a9041deea89e4), and broke sparc compilation
because of the following circular dependency:
asm-sparc/pgtable include linux/swap.h
linux/swap.h include now linux/pagemap.h
linux/pagemap.h include linux/mm.h
linux/mm.h include asm/pgtable.h

I haven't found a satisfactory way to resolve this, but i think the
patch should be removed (it removes a warning but breaks an
architecture).

Regards,

Benoit Boissinot

> Index: linux-2.6.13-rc2-olh/include/linux/pagemap.h
>  ===================================================================
> --- linux-2.6.13-rc2-olh.orig/include/linux/swap.h
> +++ linux-2.6.13-rc2-olh/include/linux/swap.h
> @@ -7,6 +7,7 @@
>  #include <linux/mmzone.h>
>  #include <linux/list.h>
>  #include <linux/sched.h>
> +#include <linux/pagemap.h>
>  #include <asm/atomic.h>
>  #include <asm/page.h>
>

Re: [PATCH] implicit declaration of function `page_cache_release'

[Olaf Hering]

 On Fri, Aug 05, Benoit Boissinot wrote:

> On 7/8/05, Olaf Hering <olh@suse.de> wrote:
> > 
> > In file included from include2/asm/tlb.h:31,
> >                  from linux-2.6.13-rc2-olh/arch/ppc64/kernel/pSeries_lpar.c:37:
> > linux-2.6.13-rc2-olh/include/asm-generic/tlb.h: In function `tlb_flush_mmu':
> > linux-2.6.13-rc2-olh/include/asm-generic/tlb.h:77: warning: implicit declaration of function `release_pages'
> > linux-2.6.13-rc2-olh/include/asm-generic/tlb.h: In function `tlb_remove_page':
> > linux-2.6.13-rc2-olh/include/asm-generic/tlb.h:117: warning: implicit declaration of function `page_cache_release'
> > 
> This went in 2.6.13-rc3 (commit
> 542d1c88bd7f73e2e59d41b12e4a9041deea89e4), and broke sparc compilation
> because of the following circular dependency:
> asm-sparc/pgtable include linux/swap.h

Why does it need swap.h? Do the users of pgtable.h rely on swap.h?

Re: [PATCH] implicit declaration of function `page_cache_release'

[Benoit Boissinot]

On 8/5/05, Olaf Hering <olh@suse.de> wrote:
>  On Fri, Aug 05, Benoit Boissinot wrote:
> 
> > On 7/8/05, Olaf Hering <olh@suse.de> wrote:
> > >
> > > In file included from include2/asm/tlb.h:31,
> > >                  from linux-2.6.13-rc2-olh/arch/ppc64/kernel/pSeries_lpar.c:37:
> > > linux-2.6.13-rc2-olh/include/asm-generic/tlb.h: In function `tlb_flush_mmu':
> > > linux-2.6.13-rc2-olh/include/asm-generic/tlb.h:77: warning: implicit declaration of function `release_pages'
> > > linux-2.6.13-rc2-olh/include/asm-generic/tlb.h: In function `tlb_remove_page':
> > > linux-2.6.13-rc2-olh/include/asm-generic/tlb.h:117: warning: implicit declaration of function `page_cache_release'
> > >
> > This went in 2.6.13-rc3 (commit
> > 542d1c88bd7f73e2e59d41b12e4a9041deea89e4), and broke sparc compilation
> > because of the following circular dependency:
> > asm-sparc/pgtable include linux/swap.h
> 
> Why does it need swap.h? Do the users of pgtable.h rely on swap.h?
> 
sparc is the only architecture to do that, it looks like it uses it
for boot time linking (BTFIXUP_*). I don't know anything about sparc,
so i can't fix it.

(adding sparclinux@vger.kernel.org to the cc list)

Re: [PATCH] implicit declaration of function `page_cache_release'

[David S. Miller]

From: Benoit Boissinot <bboissin@gmail.com>
Date: Fri, 5 Aug 2005 21:18:38 +0200

> On 8/5/05, Olaf Hering <olh@suse.de> wrote:
> >  On Fri, Aug 05, Benoit Boissinot wrote:
> > 
> > Why does it need swap.h? Do the users of pgtable.h rely on swap.h?
> > 
> sparc is the only architecture to do that, it looks like it uses it
> for boot time linking (BTFIXUP_*). I don't know anything about sparc,
> so i can't fix it.
> 
> (adding sparclinux@vger.kernel.org to the cc list)

It needs to have the swp_entry_t type fully visible in pgtable.h,
we can't work around this using macros.

Re: [PATCH] implicit declaration of function `page_cache_release'

[Olaf Hering]

 On Sat, Aug 06, David S. Miller wrote:

> From: Benoit Boissinot <bboissin@gmail.com>
> Date: Fri, 5 Aug 2005 21:18:38 +0200
> 
> > On 8/5/05, Olaf Hering <olh@suse.de> wrote:
> > >  On Fri, Aug 05, Benoit Boissinot wrote:
> > > 
> > > Why does it need swap.h? Do the users of pgtable.h rely on swap.h?
> > > 
> > sparc is the only architecture to do that, it looks like it uses it
> > for boot time linking (BTFIXUP_*). I don't know anything about sparc,
> > so i can't fix it.
> > 
> > (adding sparclinux@vger.kernel.org to the cc list)
> 
> It needs to have the swp_entry_t type fully visible in pgtable.h,
> we can't work around this using macros.

So the patch should be reverted? Its only for CONFIG_SWAP=n, rather
unusual for KDE/GNOME tainted workstations...

Re: [PATCH] implicit declaration of function `page_cache_release'

[David S. Miller]

From: Olaf Hering <olh@suse.de>
Date: Sat, 6 Aug 2005 17:01:03 +0200

> So the patch should be reverted? Its only for CONFIG_SWAP=n, rather
> unusual for KDE/GNOME tainted workstations...

Not necessarily, but the header dependencies should be fixed
up somehow.

Re: [PATCH] implicit declaration of function `page_cache_release'

[Olaf Hering]

 On Sat, Aug 06, David S. Miller wrote:

> From: Olaf Hering <olh@suse.de>
> Date: Sat, 6 Aug 2005 17:01:03 +0200
> 
> > So the patch should be reverted? Its only for CONFIG_SWAP=n, rather
> > unusual for KDE/GNOME tainted workstations...
> 
> Not necessarily, but the header dependencies should be fixed
> up somehow.

I think you are right once again.
(Just the time got a bit out of sync.)