public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rogier Wolff <R.E.Wolff@BitWizard.nl>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linus Torvalds <torvalds@osdl.org>,
	Russell King <rmk+lkml@arm.linux.org.uk>,
	Andrew Morton <akpm@osdl.org>,
	Andreas Mohr <andi@rhlx01.fht-esslingen.de>,
	florin@iucha.net, linux-kernel@vger.kernel.org,
	linux@dominikbrodowski.net
Subject: Re: pcmcia oops on 2.6.17-rc[12]
Date: Mon, 22 May 2006 13:50:46 +0200	[thread overview]
Message-ID: <20060522115046.GA23074@bitwizard.nl> (raw)
In-Reply-To: <1147734026.26686.200.camel@localhost.localdomain>

On Tue, May 16, 2006 at 12:00:26AM +0100, Alan Cox wrote:
> > So I would strongly argue that any driver that depends on getting an 
> > exclusive IRQ is buggy, not the PCMCIA layer itself, and that it would be 
> > a lot more productive to try to fix those drivers.
> 
> It would certainly be a lot cleaner than this sort of code in the pcmcia
> core right now. Want me to send a patch which only allows for SA_SHIRQ
> and WARN_ON()'s for any driver not asking for shared IRQ ?

The question I'm stuck with is: When is it valid to ask for a non-shared
IRQ, and get back a shared one. 

Drivers that know that they don't work well if they are called by the
"other" interrupt?

I happen to know (ISA) hardware that CANNOT share an interrupt: It
drives the IRQ line either high or low, and has a driver that will
overpower anything else on that line. This sounds like a good place to
me to have the driver request no sharing (*), and to prevent the IRQ
line drivers getting in eachothers way, it would be nice if the kernel
refused "early on" (i.e. before the stronger driver asserts: No IRQ
pending, and the weaker one keeps trying to assert: "YES, I have an
IRQ", and the weaker one slowly burning out).

Or am I talking nonsense again?

	Roger. 

(*) The driver knows to allow sharing when it's talking to the PCI
version of the card.

-- 
** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2600998 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
Q: It doesn't work. A: Look buddy, doesn't work is an ambiguous statement. 
Does it sit on the couch all day? Is it unemployed? Please be specific! 
Define 'it' and what it isn't doing. --------- Adapted from lxrbot FAQ

  parent reply	other threads:[~2006-05-22 11:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-23 19:22 pcmcia oops on 2.6.17-rc[12] Florin Iucha
2006-04-23 22:02 ` Andrew Morton
2006-04-23 22:15   ` Randy.Dunlap
2006-04-24  0:46   ` Florin Iucha
2006-05-08 14:56   ` Andreas Mohr
2006-05-08 15:43     ` Andrew Morton
2006-05-08 16:34       ` Russell King
2006-05-15 22:07         ` Alan Cox
2006-05-15 22:00           ` Russell King
2006-05-18 11:10             ` Russell King
2006-05-15 22:02           ` Linus Torvalds
2006-05-15 23:00             ` Alan Cox
2006-05-15 23:37               ` Linus Torvalds
2006-05-15 23:52                 ` Linus Torvalds
2006-05-16  0:17                   ` Alan Cox
2006-05-16  0:18                     ` Linus Torvalds
2006-05-16  1:18                       ` Alan Cox
2006-05-16 15:16                 ` Alan Cox
2006-05-22 11:50               ` Rogier Wolff [this message]
2006-05-22 12:10                 ` Alan Cox
2006-05-22 21:27                   ` Rogier Wolff
2006-05-22 22:38                     ` Alan Cox
2006-06-02 19:09                   ` Russell King
2006-05-22 15:06                 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060522115046.GA23074@bitwizard.nl \
    --to=r.e.wolff@bitwizard.nl \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=andi@rhlx01.fht-esslingen.de \
    --cc=florin@iucha.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=rmk+lkml@arm.linux.org.uk \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox