From: Andi Kleen <ak@suse.de>
To: "Jan Beulich" <jbeulich@novell.com>
Cc: "Ingo Molnar" <mingo@elte.hu>,
linux-kernel@vger.kernel.org, discuss@x86-64.org
Subject: Re: [PATCH 3/6] reliable stack trace support (x86-64 IRQ stack adjustment)
Date: Mon, 22 May 2006 16:10:16 +0200 [thread overview]
Message-ID: <200605221610.16909.ak@suse.de> (raw)
In-Reply-To: <4471D60F.76E4.0078.0@novell.com>
> 1: incl %gs:pda_irqcount # RED-PEN should check preempt count
> - movq %gs:pda_irqstackptr,%rax
> - cmoveq %rax,%rsp /*todo This needs CFI annotation! */
> + cmoveq %gs:pda_irqstackptr,%rsp
> +#if !defined(CONFIG_DEBUG_INFO) && !defined(CONFIG_UNWIND_INFO)
> pushq %rdi # save old stack
> -#ifndef CONFIG_DEBUG_INFO
The tests for DEBUG_INFO are obsolete here. It should only test for
UNWIND_INFO. I'll fix that up.
-Andi
prev parent reply other threads:[~2006-05-22 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-22 13:17 [PATCH 3/6] reliable stack trace support (x86-64 IRQ stack adjustment) Jan Beulich
2006-05-22 14:10 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605221610.16909.ak@suse.de \
--to=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox