From: Ingo Molnar <mingo@elte.hu>
To: Zachary Amsden <zach@vmware.com>
Cc: Andrew Morton <akpm@osdl.org>,
Arjan van de Ven <arjan@infradead.org>,
Linus Torvalds <torvalds@osdl.org>,
jakub@redhat.com, rusty@rustcorp.com.au, kraxel@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [patch 2/3] vdso: improve print_fatal_signals support by adding memory maps
Date: Wed, 24 May 2006 07:34:47 +0200 [thread overview]
Message-ID: <20060524053447.GA1934@elte.hu> (raw)
In-Reply-To: <44738C0C.9010107@vmware.com>
* Zachary Amsden <zach@vmware.com> wrote:
> >+ if (current->mm)
> >+ printk("vDSO at %p\n", current->mm->context.vdso);
> >+#endif
> > show_regs(regs);
> >+ printk("\n");
> >+ print_vmas();
> > }
> >
> > static int __init setup_print_fatal_signals(char *str
>
> Perhaps I should have read your first patch more carefully - it did
> have register info. This looks even better (although you may now want
> to allow it to be #ifdef'd out under CONFIG_EMBEDDED).
>
> You probably should use PATH_MAX+1 instead of SIZE or check IS_ERR()
> on the string from d_path.
the string is constructed on the stack, so 4K would be too much. 128 is
i think enough for most purposes.
Ingo
next prev parent reply other threads:[~2006-05-24 5:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-23 0:01 [patch 2/3] vdso: improve print_fatal_signals support by adding memory maps Ingo Molnar
2006-05-23 22:26 ` Zachary Amsden
2006-05-24 5:34 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-06-17 14:14 Simon Raffeiner
2006-06-18 4:58 ` Randy.Dunlap
2006-06-18 5:58 ` Andrew Morton
2006-06-18 13:25 ` Simon Raffeiner
2006-06-18 17:42 ` Randy.Dunlap
2006-06-18 18:29 ` Simon Raffeiner
2006-06-18 18:38 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060524053447.GA1934@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=jakub@redhat.com \
--cc=kraxel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@osdl.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox