Re: [PATCH] Add user taint flag

[Dave Jones <davej@redhat.com>]

On Wed, May 24, 2006 at 09:55:33AM -0400, Dave Jones wrote:
 > On Wed, May 24, 2006 at 09:39:16AM -0400, Theodore Tso wrote:
 >  > On Tue, May 23, 2006 at 11:45:06AM -0700, Greg KH wrote:
 >  > > On Sun, May 21, 2006 at 07:04:32PM -0400, Theodore Ts'o wrote:
 >  > > > --- linux-2.6.orig/kernel/panic.c	2006-04-28 21:16:55.000000000 -0400
 >  > > > +++ linux-2.6/kernel/panic.c	2006-05-21 19:00:15.000000000 -0400
 >  > > > @@ -150,6 +150,7 @@
 >  > > >   *  'R' - User forced a module unload.
 >  > > >   *  'M' - Machine had a machine check experience.
 >  > > >   *  'B' - System has hit bad_page.
 >  > > > + *  'U' - Userspace-defined naughtiness.
 >  > > 
 >  > > Just a note, some other distros already use the 'U' flag in taint
 >  > > messages to show an "unsupported" module has been loaded.  I know it's
 >  > > out-of-the-tree and will never go into mainline, just FYI if you happen
 >  > > to see some 'U' flags in the wild today...
 >  > > 
 >  > > Oh, and I like this feature, makes sense to me to have this.
 >  > 
 >  > Should we worry about collisions with what distributions are using?
 >  > That could cause confusion in the future....
 > 
 > We use it in Fedora/RHEL if a module is loaded that hasn't been gpg signed.
 > It's been handy to spot things like 3rd parties replacing jbd.ko with
 > their own variant in bug-reports.

Brainfart on my part. We mark such modules as (U) in the module list in oopses,
but we don't actually taint.

Meh, too early for davej's.

		Dave

-- 
http://www.codemonkey.org.uk