Re: [PATCH 1/4] x86-64: Calgary IOMMU - introduce iommu_detected

Jon Mason
2006-05-26T04:46:57Z

On Thu, May 25, 2006 at 05:54:23AM +0200, Andi Kleen wrote:
> On Thursday 25 May 2006 05:34, Jon Mason wrote:
> > swiotlb relies on the gart specific iommu_aperture variable to know if
> > we discovered a hardware IOMMU before swiotlb initialization. Introduce
> > iommu_detected to do the same thing, but in a HW IOMMU neutral manner,
> > in preparation for adding the Calgary HW IOMMU.
>
> I applied them all.
>
> But I think you broke the aperture setup. iommu_setup really
> needs to be called early, otherwise aperture.c doesn't get
> the right parameters. I undid that change.

Actually, I didn't break aperture.c by moving iommu_setup because I
moved iommu_hole_init after __setup. This change also enabled me to
move back the calgary specific bootarg parsing (like you asked for in
the original version of the path).

Also, in the reworked version of iommu-abstraction on
ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches has a bug. When
iommu_setup was kept in it's original form, the "+__setup("iommu=",
iommu_setup);" wasn't removed, which gives 2 calls to the same function.
I'll send updated versions of the patches here shortly which will apply
cleanly inplace to that tree.

>
> And please next time send against the latest tree. It required
> quite some tweaking to apply.

Sorry, I'll be happy to do it next time :)

Thanks,
Jon