From: Andi Kleen <ak@suse.de>
To: Jon Mason <jdmason@us.ibm.com>
Cc: Muli Ben-Yehuda <muli@il.ibm.com>,
Muli Ben-Yehuda <mulix@mulix.org>,
Linux-Kernel <linux-kernel@vger.kernel.org>,
discuss@x86-64.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 1/4] x86-64: Calgary IOMMU - introduce iommu_detected
Date: Fri, 26 May 2006 09:54:16 +0200 [thread overview]
Message-ID: <200605260954.17140.ak@suse.de> (raw)
In-Reply-To: <20060526044636.GA31695@us.ibm.com>
> Also, in the reworked version of iommu-abstraction on
> ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches has a bug. When
> iommu_setup was kept in it's original form, the "+__setup("iommu=",
> iommu_setup);" wasn't removed, which gives 2 calls to the same function.
> I'll send updated versions of the patches here shortly which will apply
> cleanly inplace to that tree.
That was intentional. All early boot options need a __setup too, otherwise
they will appear as variables in init's environment.
It would be only a problem if the code couldn't run twice, but that is
normally not the case.
-Andi
prev parent reply other threads:[~2006-05-26 7:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-25 3:34 [PATCH 1/4] x86-64: Calgary IOMMU - introduce iommu_detected Jon Mason
2006-05-25 3:54 ` Andi Kleen
2006-05-25 4:19 ` Jon Mason
2006-05-25 11:17 ` Muli Ben-Yehuda
2006-05-26 4:46 ` Jon Mason
2006-05-26 7:54 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605260954.17140.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=jdmason@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=muli@il.ibm.com \
--cc=mulix@mulix.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox