From: Andi Kleen <ak@suse.de>
To: Jeff Garzik <jeff@garzik.org>
Cc: discuss@x86-64.org, Muli Ben-Yehuda <mulix@mulix.org>,
Jon Mason <jdmason@us.ibm.com>, Muli Ben-Yehuda <muli@il.ibm.com>,
Linux-Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [discuss] Re: [PATCH 2/4] x86-64: Calgary IOMMU - move valid_dma_direction into the callers
Date: Fri, 26 May 2006 11:35:36 +0200 [thread overview]
Message-ID: <200605261135.36509.ak@suse.de> (raw)
In-Reply-To: <4476C27A.7040707@garzik.org>
> > On the other hand if the problem of passing wrong parameters here
> > isn't common I would be ok with dropping them.
>
> As the author noted, it was only used in early platform bring-up. And
> simply reviewing the patch... it is clear that screwing up the
> parameters would cause massive, noticeable problems immediately -- such
> as on EM64T with swiotlb.
Well the point is that even if you don't run on swiotlb
(which most people even on EM64T don't use because they don't have more than
3GB of RAM) you won't screw them up.
On the other hand correct IOMMU operation needs much more than passing
these parameters so only checking for this might not be very useful.
BTW we've had these checks forever - Jon just moved them to a different place.
But they indeed might have outlived their usefulness.
-Andi
prev parent reply other threads:[~2006-05-26 9:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-25 3:35 [PATCH 2/4] x86-64: Calgary IOMMU - move valid_dma_direction into the callers Jon Mason
2006-05-25 4:35 ` Jeff Garzik
2006-05-25 9:42 ` Muli Ben-Yehuda
2006-05-25 9:58 ` Jeff Garzik
2006-05-26 7:57 ` [discuss] " Andi Kleen
2006-05-26 8:55 ` Jeff Garzik
2006-05-26 9:35 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605261135.36509.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=jdmason@us.ibm.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muli@il.ibm.com \
--cc=mulix@mulix.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox