public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Anssi Hannula <anssi.hannula@gmail.com>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: linux-joystick@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org
Subject: [patch 13/13] input: use -ENOSPC instead of -ENOMEM in iforce when device full
Date: Fri, 26 May 2006 19:11:42 +0300	[thread overview]
Message-ID: <20060526162910.769727000@gmail.com> (raw)
In-Reply-To: 20060526161129.557416000@gmail.com

[-- Attachment #1: ff-refactoring-iforce-enomem-to-enospc.diff --]
[-- Type: text/plain, Size: 1806 bytes --]

Use -ENOSPC instead of -ENOMEM when the iforce device doesn't have enough free
memory for the new effect. All other drivers are already been using -ENOSPC,
so this makes the behaviour coherent.

Signed-off-by: Anssi Hannula <anssi.hannula@gmail.com>

---
 drivers/input/joystick/iforce/iforce-ff.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

Index: linux-2.6.17-rc4-git12/drivers/input/joystick/iforce/iforce-ff.c
===================================================================
--- linux-2.6.17-rc4-git12.orig/drivers/input/joystick/iforce/iforce-ff.c	2006-05-26 16:55:12.000000000 +0300
+++ linux-2.6.17-rc4-git12/drivers/input/joystick/iforce/iforce-ff.c	2006-05-26 16:57:13.000000000 +0300
@@ -47,7 +47,7 @@ static int make_magnitude_modifier(struc
 			iforce->device_memory.start, iforce->device_memory.end, 2L,
 			NULL, NULL)) {
 			mutex_unlock(&iforce->mem_mutex);
-			return -ENOMEM;
+			return -ENOSPC;
 		}
 		mutex_unlock(&iforce->mem_mutex);
 	}
@@ -80,7 +80,7 @@ static int make_period_modifier(struct i
 			iforce->device_memory.start, iforce->device_memory.end, 2L,
 			NULL, NULL)) {
 			mutex_unlock(&iforce->mem_mutex);
-			return -ENOMEM;
+			return -ENOSPC;
 		}
 		mutex_unlock(&iforce->mem_mutex);
 	}
@@ -120,7 +120,7 @@ static int make_envelope_modifier(struct
 			iforce->device_memory.start, iforce->device_memory.end, 2L,
 			NULL, NULL)) {
 			mutex_unlock(&iforce->mem_mutex);
-			return -ENOMEM;
+			return -ENOSPC;
 		}
 		mutex_unlock(&iforce->mem_mutex);
 	}
@@ -157,7 +157,7 @@ static int make_condition_modifier(struc
 			iforce->device_memory.start, iforce->device_memory.end, 2L,
 			NULL, NULL)) {
 			mutex_unlock(&iforce->mem_mutex);
-			return -ENOMEM;
+			return -ENOSPC;
 		}
 		mutex_unlock(&iforce->mem_mutex);
 	}

--
Anssi Hannula

      parent reply	other threads:[~2006-05-26 16:29 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-26 16:11 [patch 00/13] input: force feedback updates, second time Anssi Hannula
2006-05-26 16:11 ` [patch 01/13] input: move fixp-arith.h to drivers/input Anssi Hannula
2006-05-26 16:11 ` [patch 02/13] input: fix accuracy of fixp-arith.h Anssi Hannula
2006-05-26 16:11 ` [patch 03/13] input: make input a multi-object module Anssi Hannula
2006-05-26 21:16   ` Andrew Morton
2006-05-26 21:29     ` Anssi Hannula
2006-05-26 21:43       ` Andrew Morton
2006-05-26 21:53         ` Anssi Hannula
2006-05-26 22:08           ` Andrew Morton
2006-05-26 22:22             ` Anssi Hannula
2006-05-26 22:32               ` Andrew Morton
2006-05-26 23:07                 ` Anssi Hannula
2006-05-26 23:28                   ` Andrew Morton
2006-05-26 23:35                     ` Anssi Hannula
2006-05-26 23:45                       ` Andrew Morton
2006-05-27  0:46                         ` [patch] input: new force feedback interface Anssi Hannula
2006-05-27  0:53                         ` [patch] input: use event handler in ff drivers Anssi Hannula
2006-05-26 16:11 ` [patch 04/13] input: new force feedback interface Anssi Hannula
2006-05-26 16:11 ` [patch 05/13] input: adapt hid force feedback drivers for the new interface Anssi Hannula
2006-05-26 16:11 ` [patch 06/13] input: adapt uinput for the new force feedback interface Anssi Hannula
2006-05-26 16:11 ` [patch 07/13] input: adapt iforce driver " Anssi Hannula
2006-05-26 16:11 ` [patch 08/13] input: force feedback driver for PID devices Anssi Hannula
2006-05-26 16:11 ` [patch 09/13] input: force feedback driver for Zeroplus devices Anssi Hannula
2006-05-26 16:11 ` [patch 10/13] input: update documentation of force feedback Anssi Hannula
2006-05-26 16:11 ` [patch 11/13] input: drop the remains of the old ff interface Anssi Hannula
2006-05-26 16:11 ` [patch 12/13] input: drop the old PID driver Anssi Hannula
2006-05-26 16:11 ` Anssi Hannula [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060526162910.769727000@gmail.com \
    --to=anssi.hannula@gmail.com \
    --cc=dtor_core@ameritech.net \
    --cc=linux-joystick@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox