From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mark Knecht <markknecht@gmail.com>,
Clark Williams <williams@redhat.com>,
Robert Crocombe <rwcrocombe@raytheon.com>,
Thomas Gleixner <tglx@linutronix.de>,
john stultz <johnstul@us.ibm.com>
Subject: Re: [PATCH -rt 2/2] Fix condition in default_idle
Date: Fri, 26 May 2006 19:39:37 +0200 [thread overview]
Message-ID: <20060526173937.GC30208@elte.hu> (raw)
In-Reply-To: <20060526161036.915977618@goodmis.org>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> The condition statement in default_idle had the conjunctions
> backwards. Instead of && it had || so the idle thread would never be
> preempted.
> - while (!need_resched() || !need_resched_delayed()) {
> + while (!need_resched() && !need_resched_delayed()) {
> local_irq_disable();
> - if (!need_resched() || !need_resched_delayed())
> + if (!need_resched() && !need_resched_delayed())
doh! Good catch - applied.
Ingo
next prev parent reply other threads:[~2006-05-26 17:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-26 16:06 [PATCH -rt 0/2] Get x86_64 running with PREEMPT_RT Steven Rostedt
2006-05-26 16:06 ` [PATCH -rt 1/2] Dont blindly turn on interrupts in boot_override_clocksource Steven Rostedt
2006-05-26 17:39 ` Ingo Molnar
2006-05-26 16:06 ` [PATCH -rt 2/2] Fix condition in default_idle Steven Rostedt
2006-05-26 17:39 ` Ingo Molnar [this message]
2006-05-26 18:19 ` [PATCH -rt 0/2] Get x86_64 running with PREEMPT_RT Clark Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060526173937.GC30208@elte.hu \
--to=mingo@elte.hu \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markknecht@gmail.com \
--cc=rostedt@goodmis.org \
--cc=rwcrocombe@raytheon.com \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox