Re: [PATCH 1/10] Convert ASSERT to BUG_ON

Adrian Bunk
2006-05-26T16:43:29Z

On Fri, May 26, 2006 at 11:14:54AM -0500, Michael Halcrow wrote:
> On Fri, May 26, 2006 at 05:24:01PM +0200, Adrian Bunk wrote:
> > On Fri, May 26, 2006 at 09:21:48AM -0500, Mike Halcrow wrote:
> > > - ASSERT(auth_tok->session_key.encrypted_key_size < PAGE_CACHE_SIZE);
> > > + BUG_ON(auth_tok->session_key.encrypted_key_size > PAGE_CACHE_SIZE);
> > >...
> >
> > What's with (auth_tok->session_key.encrypted_key_size ==
> > PAGE_CACHE_SIZE) ?
>
> That should not be a problem.

IOW, the ASSERT was wrong?

My point is simply that this is not a semantically equivalent
transformation, so if this fixes a case where the ASSERT() might have
mistakenly triggered it should be noted in the changelog.

> Mike

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed