* [PATCH] blktrace_api.h: endian annotations
@ 2006-05-30 20:18 Alexey Dobriyan
2006-05-31 6:17 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2006-05-30 20:18 UTC (permalink / raw)
To: Andrew Morton; +Cc: Jens Axboe, linux-kernel
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
include/linux/blktrace_api.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- a/include/linux/blktrace_api.h
+++ b/include/linux/blktrace_api.h
@@ -89,13 +89,13 @@ struct blk_io_trace {
/*
* The remap event
*/
struct blk_io_trace_remap {
- u32 device;
+ __be32 device;
u32 __pad;
- u64 sector;
+ __be64 sector;
};
enum {
Blktrace_setup = 1,
Blktrace_running,
@@ -223,11 +223,11 @@ static inline void blk_add_trace_generic
**/
static inline void blk_add_trace_pdu_int(struct request_queue *q, u32 what,
struct bio *bio, unsigned int pdu)
{
struct blk_trace *bt = q->blk_trace;
- u64 rpdu = cpu_to_be64(pdu);
+ __be64 rpdu = cpu_to_be64(pdu);
if (likely(!bt))
return;
if (bio)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] blktrace_api.h: endian annotations
2006-05-30 20:18 [PATCH] blktrace_api.h: endian annotations Alexey Dobriyan
@ 2006-05-31 6:17 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2006-05-31 6:17 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: Andrew Morton, linux-kernel
On Wed, May 31 2006, Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
It's fine I suppose, though it doesn't add much in the way of checking.
These are the ends of the chain, it's not structures we pass around.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-05-31 6:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-30 20:18 [PATCH] blktrace_api.h: endian annotations Alexey Dobriyan
2006-05-31 6:17 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox