Re: Question about tcp hash function tcp_hashfn()

Florian Weimer
2006-06-02T07:32:28Z

* Evgeniy Polyakov:

> That is wrong. And I have a code and picture to show that,
> and you dont - prove me wrong :)

Here we go:

static inline num2ip(__u8 a1, __u8 a2, __u8 a3, __u8 a4)
{
__u32 a = 0;

a |= a1;
a << 8;
a |= a2;
a << 8;
a |= a3;
a << 8;
a |= a4;

return a;
}

"gcc -Wall" was pretty illuminating. 8-P After fixing this and
switching to a better PRNG, I get something which looks pretty normal.