From: Ingo Molnar <mingo@elte.hu>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
linux-kernel@vger.kernel.org, pauldrynoff@gmail.com,
Andrew Morton <akpm@osdl.org>
Subject: Re: 2.6.17-rc5-mm1 - output of lock validator
Date: Thu, 1 Jun 2006 10:33:14 +0200 [thread overview]
Message-ID: <20060601083314.GA25438@elte.hu> (raw)
In-Reply-To: <1149149522.3115.14.camel@laptopd505.fenrus.org>
* Arjan van de Ven <arjan@infradead.org> wrote:
> > This is a serious bug in misrouted_irq(). disable_irq() is a
> > software state and must be repsected.
>
> no that is not correct. The api is a mix kinda and broken; it really
> DOES mean "shut this irq source off". That your handler won't get
> called is an assumption! You do NOT disable your handler this way.
> What we really need is a disable_irq_handler() api that does both!
well, the short-term answer is that Herbert's fix is correct and we need
to do it even if it degrades the efficiency of irqfixup/irqpoll.
after this fix is applied, irqfixup/irqpoll should be enhanced to take
advantage of disable_irq_handler().
in any case, correctness comes first - not honoring IRQ_DISABLED can
lead to lockups.
Ingo
prev parent reply other threads:[~2006-06-01 8:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-30 15:54 2.6.17-rc5-mm1 - doesn't boot Paul Drynoff
2006-05-30 20:25 ` Andrew Morton
2006-05-31 14:19 ` 2.6.17-rc5-mm1 - output of lock validator Paul Drynoff
2006-05-31 14:28 ` Arjan van de Ven
2006-05-31 16:38 ` Paul Drynoff
2006-05-31 23:16 ` Ingo Molnar
2006-05-31 17:21 ` Andrew Morton
2006-05-31 19:44 ` Ingo Molnar
2006-05-31 21:11 ` Andrew Morton
2006-05-31 20:35 ` Arjan van de Ven
2006-05-31 21:25 ` Andrew Morton
2006-05-31 21:24 ` Arjan van de Ven
2006-06-01 8:09 ` Herbert Xu
2006-06-01 8:12 ` Arjan van de Ven
2006-06-01 8:33 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060601083314.GA25438@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=pauldrynoff@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox