Re: [PATCH] cramfs corruption after BLKFLSBUF on loop device

Olaf Hering
2006-06-02T19:37:06Z

On Fri, Jun 02, Andrew Morton wrote:

> On Fri, 2 Jun 2006 10:43:27 +0200
> Olaf Hering <olh@suse.de> wrote:
>
> > On Thu, Jun 01, Andrew Morton wrote:
> >
> >
> > > > Do you want it like that?
> > > >
> > > > lock_page(page);
> > > > if (PageUptodate(page)) {
> > > > SetPageDirty(page);
> > > > mb();
> > > > return page;
> > > > }
> > >
> > > Not really ;) It's hacky. It'd be better to take a lock.
> >
> > Which lock exactly?
>
> Ah, sorry, there isn't such a lock. I was just carrying on.
>
> > I'm not sure how to proceed from here.
>
> I'd suggest you run SetPagePrivate() and SetPageChecked() on the locked
> page and implement a_ops.releasepage(), which will fail if PageChecked(),
> and will succeed otherwise:

No leak without tweaking PG_private.