From: Jens Axboe <axboe@suse.de>
To: Chris Wright <chrisw@sous-sol.org>
Cc: linux-kernel@vger.kernel.org, stable@kernel.org,
Justin Forbes <jmforbes@linuxtx.org>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
"Theodore Ts'o" <tytso@mit.edu>,
Randy Dunlap <rdunlap@xenotime.net>,
Dave Jones <davej@redhat.com>,
Chuck Wolber <chuckw@quantumlinux.com>,
Chris Wedgewood <reviews@ml.cw.f00f.org>,
torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk,
Mark Lord <liml@rtr.ca>, Jeff Garzik <jeff@garzik.org>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH 07/11] the latest consensus libata resume fix
Date: Fri, 2 Jun 2006 21:50:46 +0200 [thread overview]
Message-ID: <20060602195046.GO4400@suse.de> (raw)
In-Reply-To: <20060602194742.420464000@sous-sol.org>
On Fri, Jun 02 2006, Chris Wright wrote:
> -stable review patch. If anyone has any objections, please let us know.
> ------------------
>
> From: Mark Lord <liml@rtr.ca>
>
> Okay, just to sum things up.
>
> This forces libata to wait for up to 2 seconds for BUSY|DRQ to clear
> on resume before continuing.
>
> [jgarzik adds...] During testing we never saw DRQ asserted, but
> nonetheless (a) this works and (b) testing for DRQ won't hurt.
>
> Signed-off-by: Mark Lord <liml@rtr.ca>
> Acked-by: Jens Axboe <axboe@suse.de>
> Signed-off-by: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Chris Wright <chrisw@sous-sol.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> ---
>
> drivers/scsi/libata-core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-2.6.16.19.orig/drivers/scsi/libata-core.c
> +++ linux-2.6.16.19/drivers/scsi/libata-core.c
> @@ -4293,6 +4293,7 @@ static int ata_start_drive(struct ata_po
> int ata_device_resume(struct ata_port *ap, struct ata_device *dev)
> {
> if (ap->flags & ATA_FLAG_SUSPENDED) {
> + ata_busy_wait(ap, ATA_BUSY | ATA_DRQ, 200000);
> ap->flags &= ~ATA_FLAG_SUSPENDED;
> ata_set_mode(ap);
> }
I'm not against the patch as such, but last I checked 2.6.16 actually
worked ok. The timer fixes in 2.6.17-rc is what apparently got the
resume breaking.
So unless there's a bug report on 2.6.16.x for this, then it's a little
against the -stable rules to add it.
--
Jens Axboe
next prev parent reply other threads:[~2006-06-02 19:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-02 19:46 [PATCH 00/11] -stable review Chris Wright
2006-06-02 7:00 ` [PATCH 01/11] Altix: correct ioc4 port order Chris Wright
2006-06-02 7:00 ` [PATCH 02/11] Altix: correct ioc3 " Chris Wright
2006-06-02 7:00 ` [PATCH 03/11] Cpuset: might sleep checking zones allowed fix Chris Wright
2006-06-02 7:00 ` [PATCH 04/11] PowerMac: force only suspend-to-disk to be valid Chris Wright
2006-06-02 7:00 ` [PATCH 05/11] Input: psmouse - fix new device detection logic Chris Wright
2006-06-02 7:00 ` [PATCH 06/11] ohci1394, sbp2: fix "scsi_add_device failed" with PL-3507 based devices Chris Wright
2006-06-02 7:00 ` [PATCH 07/11] the latest consensus libata resume fix Chris Wright
2006-06-02 19:50 ` Jens Axboe [this message]
2006-06-02 20:02 ` Greg KH
2006-06-02 20:02 ` [stable] " Chris Wright
2006-06-03 8:49 ` Marcel Holtmann
2006-06-03 13:22 ` Jens Axboe
2006-06-03 17:41 ` Chris Wright
2006-06-02 7:00 ` [PATCH 08/11] ipw2200: Filter unsupported channels out in ad-hoc mode Chris Wright
2006-06-02 7:00 ` [PATCH 09/11] x86_64: x86_64 add crashdump trigger points Chris Wright
2006-06-02 7:00 ` [PATCH 10/11] x86_64: Dont do syscall exit tracing twice Chris Wright
2006-06-02 7:00 ` [PATCH 11/11] sbp2: backport read_capacity workaround for iPod Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060602195046.GO4400@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=chrisw@sous-sol.org \
--cc=chuckw@quantumlinux.com \
--cc=davej@redhat.com \
--cc=gregkh@suse.de \
--cc=jeff@garzik.org \
--cc=jmforbes@linuxtx.org \
--cc=liml@rtr.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=reviews@ml.cw.f00f.org \
--cc=stable@kernel.org \
--cc=torvalds@osdl.org \
--cc=tytso@mit.edu \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox