From: Con Kolivas <kernel@kolivas.org>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: "'Andrew Morton'" <akpm@osdl.org>,
"'Nick Piggin'" <nickpiggin@yahoo.com.au>,
"'Chris Mason'" <mason@suse.com>, "Ingo Molnar" <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] fix smt nice lock contention and optimization
Date: Sat, 3 Jun 2006 17:52:58 +1000 [thread overview]
Message-ID: <200606031752.59532.kernel@kolivas.org> (raw)
In-Reply-To: <000701c686e1$71f2f7f0$df34030a@amr.corp.intel.com>
On Saturday 03 June 2006 17:43, Chen, Kenneth W wrote:
> OK, final rolled up patch with everyone's changes. I fixed one bug
> introduced by Con's earlier patch that there is an unpaired
> spin_trylock/spin_unlock in the for loop of dependent_sleeper().
> Chris, Con, Nick - please review and provide your signed-off-by line.
> Andrew - please consider for -mm inclusion. Thanks.
Looks good. Just one style nitpick.
> for_each_domain(this_cpu, tmp)
> - if (tmp->flags & SD_SHARE_CPUPOWER)
> + if (tmp->flags & SD_SHARE_CPUPOWER) {
> sd = tmp;
> -
> + break;
> + }
Could we make this neater with extra braces such as:
for_each_domain(this_cpu, tmp) {
if (tmp->flags & SD_SHARE_CPUPOWER) {
sd = tmp;
break;
}
}
and same for the other uses of for_each ? I know it's redundant but it's
neater IMO when there are multiple lines of code below it.
--
-ck
next prev parent reply other threads:[~2006-06-03 7:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-03 7:43 [patch] fix smt nice lock contention and optimization Chen, Kenneth W
2006-06-03 7:49 ` Ingo Molnar
2006-06-03 8:11 ` Andrew Morton
2006-06-03 8:17 ` Chen, Kenneth W
2006-06-03 8:22 ` Andrew Morton
2006-06-03 7:52 ` Con Kolivas [this message]
2006-06-03 7:57 ` Ingo Molnar
2006-06-03 8:12 ` Chen, Kenneth W
2006-06-03 8:17 ` Con Kolivas
2006-06-03 8:52 ` Nick Piggin
2006-06-03 18:45 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200606031752.59532.kernel@kolivas.org \
--to=kernel@kolivas.org \
--cc=akpm@osdl.org \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mason@suse.com \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox