Re: [PATCH RFC 0/11] usbserial: Serial Core port.

["Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br>]

On Fri, 2 Jun 2006 13:48:39 -0700
Greg KH <gregkh@suse.de> wrote:

| On Fri, Jun 02, 2006 at 12:03:06AM -0300, Luiz Fernando N.Capitulino wrote:
| > 
| >  Hi folks.
| > 
| >  This patch series is my first attempt to port the USB-Serial layer to the
| > Serial Core API. Currently USB-Serial uses the TTY layer directly, duplicating
| > code and solutions from the Serial Core implementation.
| > 
| >  The final (ported) USB-Serial code is simpler and cleaner. Now I'd like to know
| > whether I'm doing it right or not.
| > 
| >  Note that this is a work in progress though. I've only ported the USB-Serial
| > core and one of its drivers, the pl2303 one.
| > 
| >  Most of my questions and design decisions are adressed in the patches, please
| > refer to them for details.
| 
| Nice first cut at this.  But please try to also convert 2 other drivers
| at the same time to make sure that the model is right.  I'd suggest the
| io_edgeport and the funsoft drivers.  io_edgeport because it is very
| complex in that it doesn't share a single bulk in/out pair for every
| port, but multiplexes them all through one pipe.  And funsoft because we
| want to still be able to write usb-serial drivers that are this simple.

 I'd love to do that but, unfortunatally, USB-Serial cables are too
expensive in Brazil (and I have no sure if I can find these ones in
Curitiba).

 The Prolific 2303 cables I have were lent by Mandriva.

 Couldn't someone send these cables for me in Brazil? I can send they
back when the port is finished.

| I agree with most of Pete's comments and like the general idea of moving
| the usb-serial core to be more like libata (provider of helper
| functions, not getting in the middle of everything).  I'll wait for your
| next cut to provide specific code comments.

 Hope to have something to show in the next days.

-- 
Luiz Fernando N. Capitulino