From: Andi Kleen <ak@suse.de>
To: Joachim Fritschi <jfritschi@freenet.de>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
herbert@gondor.apana.org.au
Subject: Re: [PATCH 4/4] Twofish cipher - x86_64 assembler
Date: Sun, 4 Jun 2006 21:10:14 +0200 [thread overview]
Message-ID: <200606042110.15060.ak@suse.de> (raw)
In-Reply-To: <200606041516.46920.jfritschi@freenet.de>
On Sunday 04 June 2006 15:16, Joachim Fritschi wrote:
> This patch adds the twofish x86_64 assembler routine.
>
> Changes since last version:
> - The keysetup is now handled by the twofish_common.c (see patch 1 )
> - The last round of the encrypt/decrypt routines where optimized saving 5
> instructions.
>
> Correctness was verified with the tcrypt module and automated test scripts.
Do you have some benchmark numbers that show that it's actually worth
it?
> +/* Defining a few register aliases for better reading */
Maybe you can read it now better, but for everybody else it is extremly
confusing. It would be better if you just used the original register names.
-andi
next prev parent reply other threads:[~2006-06-04 20:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-04 13:16 [PATCH 4/4] Twofish cipher - x86_64 assembler Joachim Fritschi
2006-06-04 19:10 ` Andi Kleen [this message]
2006-06-04 21:01 ` Dag Arne Osvik
2006-06-05 10:18 ` Joachim Fritschi
2006-06-05 22:28 ` Dag Arne Osvik
2006-06-05 22:44 ` Dag Arne Osvik
2006-06-07 19:16 ` Joachim Fritschi
2006-06-05 10:06 ` Joachim Fritschi
2006-06-05 17:44 ` dean gaudet
2006-06-05 19:46 ` Joachim Fritschi
2006-06-05 23:35 ` Andi Kleen
2006-06-07 19:21 ` Joachim Fritschi
2006-06-07 19:38 ` Joachim Fritschi
2006-06-16 12:00 ` Joachim Fritschi
2006-06-17 10:38 ` Joachim Fritschi
2006-06-19 14:13 ` Joachim Fritschi
2006-06-20 11:14 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2006-06-08 7:13 linux
2006-06-08 17:35 ` Joachim Fritschi
2006-06-09 1:13 ` linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200606042110.15060.ak@suse.de \
--to=ak@suse.de \
--cc=herbert@gondor.apana.org.au \
--cc=jfritschi@freenet.de \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox