From: Catalin Marinas <catalin.marinas@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH 2.6.17-rc5 7/8] Remove some of the kmemleak false positives
Date: Sun, 04 Jun 2006 23:00:51 +0100 [thread overview]
Message-ID: <20060604220050.16277.69063.stgit@localhost.localdomain> (raw)
In-Reply-To: <20060604215636.16277.15454.stgit@localhost.localdomain>
From: Catalin Marinas <catalin.marinas@arm.com>
There are allocations for which the main pointer cannot be found but they
are not memory leaks. This patch fixes some of them.
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
---
arch/i386/kernel/setup.c | 1 +
ipc/util.c | 2 ++
kernel/params.c | 7 +++++--
mm/slab.c | 1 +
4 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/arch/i386/kernel/setup.c b/arch/i386/kernel/setup.c
index 846e163..7c18c88 100644
--- a/arch/i386/kernel/setup.c
+++ b/arch/i386/kernel/setup.c
@@ -1323,6 +1323,7 @@ legacy_init_iomem_resources(struct resou
if (e820.map[i].addr + e820.map[i].size > 0x100000000ULL)
continue;
res = kzalloc(sizeof(struct resource), GFP_ATOMIC);
+ memleak_not_leak(res);
switch (e820.map[i].type) {
case E820_RAM: res->name = "System RAM"; break;
case E820_ACPI: res->name = "ACPI Tables"; break;
diff --git a/ipc/util.c b/ipc/util.c
index 8193299..dcf3e2d 100644
--- a/ipc/util.c
+++ b/ipc/util.c
@@ -389,6 +389,7 @@ void* ipc_rcu_alloc(int size)
*/
if (rcu_use_vmalloc(size)) {
out = vmalloc(HDRLEN_VMALLOC + size);
+ memleak_not_leak(out);
if (out) {
out += HDRLEN_VMALLOC;
container_of(out, struct ipc_rcu_hdr, data)->is_vmalloc = 1;
@@ -396,6 +397,7 @@ void* ipc_rcu_alloc(int size)
}
} else {
out = kmalloc(HDRLEN_KMALLOC + size, GFP_KERNEL);
+ memleak_not_leak(out);
if (out) {
out += HDRLEN_KMALLOC;
container_of(out, struct ipc_rcu_hdr, data)->is_vmalloc = 0;
diff --git a/kernel/params.c b/kernel/params.c
index af43ecd..a30beaf 100644
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -548,6 +548,7 @@ static void __init kernel_param_sysfs_se
unsigned int name_skip)
{
struct module_kobject *mk;
+ struct module_param_attrs *mp;
mk = kzalloc(sizeof(struct module_kobject), GFP_KERNEL);
BUG_ON(!mk);
@@ -557,11 +558,13 @@ static void __init kernel_param_sysfs_se
kobject_set_name(&mk->kobj, name);
kobject_register(&mk->kobj);
+ mp = param_sysfs_setup(mk, kparam, num_params, name_skip);
/* no need to keep the kobject if no parameter is exported */
- if (!param_sysfs_setup(mk, kparam, num_params, name_skip)) {
+ if (!mp) {
kobject_unregister(&mk->kobj);
kfree(mk);
- }
+ } else
+ memleak_not_leak(mp);
}
/*
diff --git a/mm/slab.c b/mm/slab.c
index 0d38f74..395e7bb 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -3357,6 +3357,7 @@ void *__alloc_percpu(size_t size)
memset(pdata->ptrs[i], 0, size);
}
+ memleak_not_leak(pdata);
/* Catch derefs w/o wrappers */
return (void *)(~(unsigned long)pdata);
next prev parent reply other threads:[~2006-06-04 22:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-04 21:56 [PATCH 2.6.17-rc5 0/8] Kernel memory leak detector 0.5 Catalin Marinas
2006-06-04 21:59 ` [PATCH 2.6.17-rc5 1/8] Base support for kmemleak Catalin Marinas
2006-06-04 22:00 ` [PATCH 2.6.17-rc5 2/8] Some documentation " Catalin Marinas
2006-06-04 22:00 ` [PATCH 2.6.17-rc5 3/8] Add the memory allocation/freeing hooks " Catalin Marinas
2006-06-04 22:00 ` [PATCH 2.6.17-rc5 4/8] Modules support " Catalin Marinas
2006-06-04 22:00 ` [PATCH 2.6.17-rc5 5/8] Add kmemleak support for i386 Catalin Marinas
2006-06-04 22:00 ` [PATCH 2.6.17-rc5 6/8] Add kmemleak support for ARM Catalin Marinas
2006-06-04 22:00 ` Catalin Marinas [this message]
2006-06-04 22:00 ` [PATCH 2.6.17-rc5 8/8] Simple testing for kmemleak Catalin Marinas
2006-06-05 21:52 ` [PATCH 2.6.17-rc5 0/8] Kernel memory leak detector 0.5 Michal Piotrowski
2006-06-06 8:25 ` Catalin Marinas
2006-06-07 1:08 ` Keith Owens
2006-06-06 8:47 ` Catalin Marinas
2006-06-06 10:46 ` Catalin Marinas
2006-06-06 15:50 ` Michal Piotrowski
2006-06-06 15:59 ` Catalin Marinas
-- strict thread matches above, loose matches on Subject: below --
2006-06-03 8:10 [PATCH 2.6.17-rc5 0/8] Kernel memory leak detector 0.4 Catalin Marinas
2006-06-03 8:11 ` [PATCH 2.6.17-rc5 7/8] Remove some of the kmemleak false positives Catalin Marinas
2006-06-03 20:48 ` Pavel Machek
2006-06-03 21:05 ` Catalin Marinas
2006-06-03 21:30 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060604220050.16277.69063.stgit@localhost.localdomain \
--to=catalin.marinas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox