From: Andrew Morton <akpm@osdl.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, tglx@linutronix.de,
torvalds@osdl.org
Subject: Re: [RFC][PATCH] request_irq(...,SA_BOOTMEM);
Date: Mon, 5 Jun 2006 01:57:02 -0700 [thread overview]
Message-ID: <20060605015702.115597cf.akpm@osdl.org> (raw)
In-Reply-To: <1149497376.8543.65.camel@localhost.localdomain>
On Mon, 05 Jun 2006 18:49:36 +1000
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> > And yes, the mutex code will (with debug enabled) unconditionally enable
> > interrupts. ppc64 tends to oops when this happens, in the timer handler
> > (so it'll be intermittent...)
>
> I tend to say that any code that hard-enables interrupts is looking for
> trouble (mostly for that very reason of init stuff).
Usually. But it's 100% daft to be preserving local irq state in
mutex_lock().
next prev parent reply other threads:[~2006-06-05 8:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-05 5:40 [RFC][PATCH] request_irq(...,SA_BOOTMEM); Benjamin Herrenschmidt
2006-06-05 7:08 ` Benjamin Herrenschmidt
2006-06-05 7:31 ` Andrew Morton
2006-06-05 7:48 ` Benjamin Herrenschmidt
2006-06-05 8:24 ` Andrew Morton
2006-06-05 8:49 ` Benjamin Herrenschmidt
2006-06-05 8:57 ` Andrew Morton [this message]
2006-06-05 9:01 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060605015702.115597cf.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox